geomind_code/zinit
22
0
Fork 0
Code Issues 5 Pull requests 4 Projects Releases Packages 1 Wiki Activity Actions

fix missing herolib_core workspace dependency #25

Open
mik-tf wants to merge 1 commit from development_fix_herolib_core_dep into development
pull from: development_fix_herolib_core_dep
merge into: geomind_code:development
Conversation 0 Commits 1 Files changed 1 +1
mik-tf commented 2026-03-01 03:38:13 +00:00
Member
Copy link

Summary

  • Add herolib_core to [workspace.dependencies] in root Cargo.toml
  • zinit_sdk references it as workspace = true but it was never defined
  • This broke all downstream git consumers of zinit_sdk

Closes #24

Test plan

  • cargo metadata resolves successfully
  • cargo build completes for the full workspace
  • Downstream hero_services can resolve zinit_sdk from this branch
## Summary - Add `herolib_core` to `[workspace.dependencies]` in root `Cargo.toml` - `zinit_sdk` references it as `workspace = true` but it was never defined - This broke all downstream git consumers of `zinit_sdk` Closes #24 ## Test plan - [ ] `cargo metadata` resolves successfully - [ ] `cargo build` completes for the full workspace - [ ] Downstream `hero_services` can resolve `zinit_sdk` from this branch
fix: add missing herolib_core to workspace dependencies
Some checks failed
Build and Test / build (pull_request) Failing after 38s
Details
Tests / test (push) Failing after 1m1s
Details
Build and Test / build (push) Failing after 1m5s
Details
Tests / test (pull_request) Failing after 1m25s
Details
48b285dafc 
Commit 11a6bd4 added herolib_core as a dependency in zinit_sdk
(workspace = true, optional = true) but did not add it to the
workspace root [workspace.dependencies]. This breaks cargo resolution
for any downstream crate that depends on zinit_sdk via git.
mik-tf changed title from WIP: fix missing herolib_core workspace dependency to fix missing herolib_core workspace dependency 2026-03-01 04:14:10 +00:00
Some checks failed
Build and Test / build (pull_request) Failing after 38s
Details
Tests / test (push) Failing after 1m1s
Details
Build and Test / build (push) Failing after 1m5s
Details
Tests / test (pull_request) Failing after 1m25s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin development_fix_herolib_core_dep:development_fix_herolib_core_dep
git switch development_fix_herolib_core_dep

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development
git merge --no-ff development_fix_herolib_core_dep
git switch development_fix_herolib_core_dep
git rebase development
git switch development
git merge --ff-only development_fix_herolib_core_dep
git switch development_fix_herolib_core_dep
git rebase development
git switch development
git merge --no-ff development_fix_herolib_core_dep
git switch development
git merge --squash development_fix_herolib_core_dep
git switch development
git merge --ff-only development_fix_herolib_core_dep
git switch development
git merge development_fix_herolib_core_dep
git push origin development
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
geomind_code/zinit!25
No description provided.