development branch broken: herolib_core missing from workspace dependencies #24

New issue

Open

opened 2026-03-01 03:38:05 +00:00 by mik-tf · 0 comments

mik-tf commented

2026-03-01 03:38:05 +00:00

Member

Problem

Commit 11a6bd4 ("refactor: use herolib_core instead of herolib_clients for openrpc macro") added herolib_core as a workspace dependency in crates/zinit_sdk/Cargo.toml:

herolib_core = { workspace = true, optional = true }

But herolib_core was never added to [workspace.dependencies] in the root Cargo.toml. The follow-up commit 60e2d74 only removed a bad feature flag but did not fix the missing workspace dep.

Impact

Any downstream crate that depends on zinit_sdk via git (e.g. hero_services) fails with:

error: no matching package named `zinit_sdk` found
location searched: Git repository https://forge.ourworld.tf/geomind_code/zinit.git?branch=development

This blocks all Docker builds of the hero service stack.

Fix

Add to root Cargo.toml [workspace.dependencies]:

herolib_core = { git = "https://forge.ourworld.tf/lhumina_code/hero_lib.git", branch = "development", default-features = false }

## Problem Commit `11a6bd4` ("refactor: use herolib_core instead of herolib_clients for openrpc macro") added `herolib_core` as a workspace dependency in `crates/zinit_sdk/Cargo.toml`: ```toml herolib_core = { workspace = true, optional = true } ``` But `herolib_core` was never added to `[workspace.dependencies]` in the root `Cargo.toml`. The follow-up commit `60e2d74` only removed a bad feature flag but did not fix the missing workspace dep. ## Impact Any downstream crate that depends on `zinit_sdk` via git (e.g. `hero_services`) fails with: ``` error: no matching package named `zinit_sdk` found location searched: Git repository https://forge.ourworld.tf/geomind_code/zinit.git?branch=development ``` This blocks all Docker builds of the hero service stack. ## Fix Add to root `Cargo.toml` `[workspace.dependencies]`: ```toml herolib_core = { git = "https://forge.ourworld.tf/lhumina_code/hero_lib.git", branch = "development", default-features = false } ```