lhumina_code/hero_skills
2
0
Fork 0
Code Issues 10 Pull requests Projects Releases 1 Packages 1 Wiki Activity Actions

Fix init commands #64

Closed
sameh-farouk wants to merge 1 commit from development-fix-init into development
pull from: development-fix-init
merge into: lhumina_code:development
Conversation 1 Commits 1 Files changed 2 +2 -2
sameh-farouk commented 2026-03-24 12:37:32 +00:00
Member
Copy link
  • passes TOOLS_DIR env var so install.nu finds the modules directory
  • Fix function defined as main instead of "init main"

fixes

- passes TOOLS_DIR env var so install.nu finds the modules directory - Fix function defined as main instead of "init main" fixes - https://forge.ourworld.tf/lhumina_code/hero_skills/issues/66 - https://forge.ourworld.tf/lhumina_code/hero_skills/issues/65
sameh-farouk removed their assignment 2026-03-24 15:39:09 +00:00
sameh-farouk commented 2026-04-21 17:26:22 +00:00
Author
Member
Copy link

Superseded. Both underlying issues are resolved in current development via different commits than this PR proposed:

  • #65 (TOOLS_DIR not reaching install): install.sh:564 now writes $env.HERO_TOOLS_DIR = '<tools_dir>' into the generated config.nu, which init.nu:23 reads. Different env var name (HERO_TOOLS_DIR instead of TOOLS_DIR) — same outcome.
  • #66 (init main parser error): init.nu:85 is now export def --env "init main" [].

Additionally, tools/install.nu was replaced by tools/install.sh (commit 98e59d0 refactor: migrate install.nu references to install.sh), so this branch's diff wouldn't apply even without the rebase conflict.

Closing.

Superseded. Both underlying issues are resolved in current `development` via different commits than this PR proposed: - #65 (TOOLS_DIR not reaching install): `install.sh:564` now writes `$env.HERO_TOOLS_DIR = '<tools_dir>'` into the generated `config.nu`, which `init.nu:23` reads. Different env var name (`HERO_TOOLS_DIR` instead of `TOOLS_DIR`) — same outcome. - #66 (`init main` parser error): `init.nu:85` is now `export def --env "init main" []`. Additionally, `tools/install.nu` was replaced by `tools/install.sh` (commit `98e59d0 refactor: migrate install.nu references to install.sh`), so this branch's diff wouldn't apply even without the rebase conflict. Closing.
sameh-farouk closed this pull request 2026-04-21 17:26:23 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_skills!64
No description provided.