lhumina_code/hero_skills
24
0
Fork 0
Code Issues 5 Pull requests 1 Projects Releases 1 Packages 1 Wiki Activity Actions

fix: correct hero:theme protocol and establish single source of truth #61

Closed
mik-tf wants to merge 1 commit from development_theme-sync-protocol into development
pull from: development_theme-sync-protocol
merge into: lhumina_code:development
Conversation 0 Commits 1 Files changed 2 +139 -59
mik-tf commented 2026-03-19 14:41:42 +00:00
Owner
Copy link

Summary

  • Fixed wrong postMessage type in hero_ui_dashboard skill (hero-os-theme → hero:theme)
  • Added complete hero:theme iframe sync protocol to web_embed skill (message format, canonical receiver snippet, CSS variable mapping, standalone fallback)
  • Removed duplicated protocol code from hero_ui_dashboard, replaced with reference to web_embed
  • Added web_embed to hero_ui_dashboard related skills

Closes #59
Related: lhumina_code/hero_aibroker#17

Test plan

  • Verify web_embed skill triggers correctly when working on iframe embedding
  • Verify hero_ui_dashboard skill references web_embed for theme protocol
  • Confirm protocol matches production repos (hero_redis, hero_foundry_ui, hero_aibroker)
## Summary - Fixed wrong postMessage type in `hero_ui_dashboard` skill (`hero-os-theme` → `hero:theme`) - Added complete `hero:theme` iframe sync protocol to `web_embed` skill (message format, canonical receiver snippet, CSS variable mapping, standalone fallback) - Removed duplicated protocol code from `hero_ui_dashboard`, replaced with reference to `web_embed` - Added `web_embed` to `hero_ui_dashboard` related skills Closes #59 Related: https://forge.ourworld.tf/lhumina_code/hero_aibroker/issues/17 ## Test plan - [ ] Verify `web_embed` skill triggers correctly when working on iframe embedding - [ ] Verify `hero_ui_dashboard` skill references `web_embed` for theme protocol - [ ] Confirm protocol matches production repos (hero_redis, hero_foundry_ui, hero_aibroker)
The hero_ui_dashboard skill had the wrong postMessage type (hero-os-theme
instead of hero:theme) and was missing the vars/CSS variable injection
that all production repos actually use. Moved the canonical theme sync
protocol to web_embed as the single source of truth, and updated
hero_ui_dashboard to reference it instead of duplicating.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mik-tf closed this pull request 2026-03-19 14:42:28 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_skills!61
No description provided.