fix(skills): apply audit fixes — TCP refs, buildenv sourcing, layout notes #149
No reviewers
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_skills!149
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "development_skill_hero_rust_repo_create"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Follow-up to #144 — applies the audit findings against the canonical Hero workspace pattern, plus picks up an in-flight
.gitignorecleanup from the working tree.Skill-content fixes (commit
4be6571)Six skills updated based on the audit run after #144 landed.
HIGH severity
forge-release-workflow— the release-upload step was sourcingbuildenv.shdirectly. Per/build_lib's own rule ("never sourcebuildenv.shdirectly"), now sourcesbuild_lib.sh, which auto-loadsbuildenv.shfrom the right place. Comment in the YAML calls out the rule explicitly.hero_books— rewrote the "Quick Start", "Running Hero Books", PDF, and Troubleshooting sections. Removed all TCP references (--port 8883,http://localhost:8883/...) and the now-defuncthero_books_clientbinary. Replaced with the canonical Unix-socket pattern:hero_books --start,~/hero/var/sockets/hero_books/{rpc,ui,web_admin}.sock,curl --unix-socketfor direct access,hero_routerfor HTTP fan-out. Added cross-references to/hero_sockets,/hero_proc_service_selfstart,/hero_router. Documented thedocs.*RPC method set.MEDIUM severity
forge-release-workflow— now describesscripts/as the canonical location and root as legacy fallback, instead of treating both as equal. Description, body prose, and decision-rule bullet all updated.rhai_bindings_troubleshooting— the "Workspace Cargo.toml additions" section showed a workspace-root[[bin]]that conflicts with the canonical pure-workspace layout. Added a callout pointing at/hero_rust_repo_create— in modern repos,hero_do_<workspace>lives in its owncrates/<n>_lib_rhai/crate, not at the root.hero_crates_best_practices_check— Check 9 (Root runtime orchestration) gains an explicit one-line rule: only the unsuffixed CLI gets--start/--stop/--status;_server,_ui,_adminmust run plain foreground. Cross-link to/hero_proc_service_selfstart.LOW severity
naming_convention— the[[bin]] namerow in the Rust table now states explicitly that this lives in the per-crateCargo.tomlundercrates/<n>/, never in the workspace-rootCargo.toml. Added a pointer paragraph to/hero_rust_repo_create.Self-fix
hero_rust_repo_create— replaced a stale link to/rhai_bindings_generate_fix(since consolidated into/rhai_bindings_troubleshooting) with the current skill name.Gitignore cleanup (commit
0855517, by Mahmoud)Adds
.claudeto.gitignoreand removes the previously-committed.claude/settings.local.jsonso per-user IDE state stops landing in the repo.Test plan
cd claude/skills && grep -rln "rhai_bindings_generate_fix\|rhai_bindings_client_fix\|rhai_bindings_cmd_path"returns nothing8883,--port,hero_books_client, or directsource buildenv.shreferences in the affected skills🤖 Generated with Claude Code
Six skills updated based on the audit run after hero_books / hero_compute alignment landed. HIGH severity - forge-release-workflow: the release-upload step was sourcing buildenv.sh directly. Per /build_lib's own rule ("never source buildenv.sh directly"), now sources build_lib.sh, which auto-loads buildenv.sh from the right location. Comment in the YAML calls out the rule explicitly. - hero_books: rewrote the "Quick Start", "Running Hero Books", PDF, and Troubleshooting sections. Removed all TCP references (--port 8883, http://localhost:8883/...) and the now-defunct hero_books_client binary. Replaced with the canonical Unix-socket pattern: hero_books --start, ~/hero/var/sockets/hero_books/{rpc,ui,web_admin}.sock, curl --unix-socket for direct access, hero_router for HTTP fan-out. Added cross-references to /hero_sockets, /hero_proc_service_selfstart, /hero_router. Documented the docs.* RPC method set briefly. MEDIUM severity - forge-release-workflow: now describes scripts/ as the canonical location and root as legacy fallback, instead of treating both as equal. Description, body prose, and decision-rule bullet all updated. - rhai_bindings_troubleshooting: the "Workspace Cargo.toml additions" section showed a workspace-root [[bin]] that conflicts with the canonical pure-workspace layout. Added a callout pointing at /hero_rust_repo_create — in modern repos, hero_do_<workspace> lives in its own crates/<n>_lib_rhai/ crate, not at the root. - hero_crates_best_practices_check: Check 9 (Root runtime orchestration) gains an explicit one-line rule: only the unsuffixed CLI gets --start/--stop/--status; _server, _ui, _admin must run plain foreground. Cross-link to /hero_proc_service_selfstart. LOW severity - naming_convention: the [[bin]] name row in the Rust table now states explicitly that this lives in the per-crate Cargo.toml under crates/<n>/, never in the workspace-root Cargo.toml. Added a pointer paragraph to /hero_rust_repo_create. Self-fix - hero_rust_repo_create: replaced a stale link to /rhai_bindings_generate_fix (since consolidated into /rhai_bindings_troubleshooting) with the current skill name. Verified: cd claude/skills && grep -rln stale-symbol-set returns nothing.