lhumina_code/hero_skills
4
0
Fork 0
Code Issues 35 Pull requests Projects Releases 1 Packages 1 Wiki Activity Actions

Update hero_service_scaffold skill + regenerate hero_service template repo for new docs/openrpc.json location #274

New issue
Closed
opened 2026-05-20 06:53:08 +00:00 by timur · 2 comments
timur commented 2026-05-20 06:53:08 +00:00
Owner
Copy link

Context

Follow-up from hero_rpc#73 (PR #81 merged). Generator now emits <workspace>/docs/openrpc.json instead of per-domain crates/<name>/src/<domain>/openrpc.json. The #73 agent flagged two cross-repo follow-ups as out-of-scope; this tracks both.

Tasks

A — Update hero_service_scaffold.md skill

File: skills/hero/service/hero_service_scaffold.md. Wherever the generated layout mentions openrpc.json (or the old src/<domain>/openrpc.json path), update to reflect the new canonical docs/openrpc.json at the workspace root. Also update the hero_service_check_fix.md skill if it references the old path.

B — Regenerate hero_service template repo

The hero_service template repo was scaffolded before #73 landed, so its openrpc.json is in the old location. Re-run the scaffolder (or hand-edit) so its layout matches the new convention.

Files likely affected:

  • Move (or regenerate) the openrpc.json output to docs/openrpc.json
  • Remove src/.../openrpc.json from hero_service
  • Verify the <hero-api-docs> integration in hero_service_admin still resolves
  • Verify cargo build --workspace clean + lab infocheck clean

Out of scope

Multi-domain spec-merge (where a service has multiple OSchema domains, how to merge their per-domain method sets into one docs/openrpc.json) — separate follow-up for the hero_rpc generator.

Acceptance

  • Skill docs reflect the new path.
  • hero_service template repo matches the new layout.
  • <hero-api-docs> in hero_service_admin still loads the spec correctly.
## Context Follow-up from [hero_rpc#73](https://forge.ourworld.tf/lhumina_code/hero_rpc/issues/73) (PR #81 merged). Generator now emits `<workspace>/docs/openrpc.json` instead of per-domain `crates/<name>/src/<domain>/openrpc.json`. The #73 agent flagged two cross-repo follow-ups as out-of-scope; this tracks both. ## Tasks ### A — Update `hero_service_scaffold.md` skill File: `skills/hero/service/hero_service_scaffold.md`. Wherever the generated layout mentions `openrpc.json` (or the old `src/<domain>/openrpc.json` path), update to reflect the new canonical `docs/openrpc.json` at the workspace root. Also update the `hero_service_check_fix.md` skill if it references the old path. ### B — Regenerate `hero_service` template repo The [hero_service](https://forge.ourworld.tf/lhumina_code/hero_service) template repo was scaffolded before #73 landed, so its openrpc.json is in the old location. Re-run the scaffolder (or hand-edit) so its layout matches the new convention. Files likely affected: - Move (or regenerate) the openrpc.json output to `docs/openrpc.json` - Remove `src/.../openrpc.json` from `hero_service` - Verify the `<hero-api-docs>` integration in `hero_service_admin` still resolves - Verify `cargo build --workspace` clean + `lab infocheck` clean ## Out of scope Multi-domain spec-merge (where a service has multiple OSchema domains, how to merge their per-domain method sets into one `docs/openrpc.json`) — separate follow-up for the hero_rpc generator. ## Acceptance - Skill docs reflect the new path. - `hero_service` template repo matches the new layout. - `<hero-api-docs>` in `hero_service_admin` still loads the spec correctly.
timur commented 2026-05-20 07:50:04 +00:00
Author
Owner
Copy link

PR opened: #276 (skill-doc half). Template repo regen follows separately on hero_service development.

PR opened: #276 (skill-doc half). Template repo regen follows separately on hero_service `development`.
timur commented 2026-05-20 07:53:18 +00:00
Author
Owner
Copy link

Template repo regenerated: lhumina_code/hero_service@af96639 pushed to development. Layout now matches hero_rpc#82 (aggregate docs/openrpc.json + per-domain docs/catalog/openrpc.json). cargo build --workspace clean. Both halves of #274 are now done — closing on PR #276 merge.

Template repo regenerated: lhumina_code/hero_service@af96639 pushed to `development`. Layout now matches hero_rpc#82 (aggregate `docs/openrpc.json` + per-domain `docs/catalog/openrpc.json`). `cargo build --workspace` clean. Both halves of #274 are now done — closing on PR #276 merge.
timur closed this issue 2026-05-20 08:16:44 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
development
issue-98-scaffold-docs
issue-96-generated-folders
issue-274-multidomain-openrpc-docs
issue-271-service-map-hero-logic
issue-71-drop-docs-schemas-ref
lab-add-hero-service
pr-260-new-skills
development_timur
docs/setup-bootstrap-adr
main
lab-latest
latest
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_skills#274
No description provided.