fix: port standardization, Makefile cleanup, and service fixes #13

Closed

mik-tf wants to merge 9 commits from development_heroports into development

pull from: development_heroports

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:main

Conversation 0 Commits 9 Files changed 21 +260 -165

mik-tf commented 2026-02-13 21:31:29 +00:00

Owner

Copy link

Summary

• Standardize all service ports to match hero_ports registry
• Add hero_launcher service template (port 3394)
• Fix hero_redis crash: disable web UI to prevent template conflict
• Standardize Makefile per makefile_helper skill (logic in scripts/)
• Fix stale ports in workflows, tests, examples, and docs

Test plan

• make run starts all 16 services on correct ports
• hero_redis stays running (no template parse crash)
• All HTTP services respond on correct ports
• hero_os WASM can reach all backends

## Summary - Standardize all service ports to match hero_ports registry - Add hero_launcher service template (port 3394) - Fix hero_redis crash: disable web UI to prevent template conflict - Standardize Makefile per makefile_helper skill (logic in scripts/) - Fix stale ports in workflows, tests, examples, and docs ## Test plan - [ ] `make run` starts all 16 services on correct ports - [ ] hero_redis stays running (no template parse crash) - [ ] All HTTP services respond on correct ports - [ ] hero_os WASM can reach all backends

mik-tf added 1 commit 2026-02-13 21:31:29 +00:00

fix: standardize hero_os port to 8880 (88xx frontend convention) ... 346ca12b28

- Replace hero_wasmos references with hero_os
- Align all port references to 8880 (was 3388/8201)
- hero_wasmos is archived, hero_os is the active frontend

mik-tf added 1 commit 2026-02-14 02:44:20 +00:00

fix: add hero_launcher port 3394 and explicit listen address 2ceffeb04b

mik-tf added 1 commit 2026-02-14 02:52:05 +00:00

fix: add redis auth and docker runtime to hero_launcher service config 023ee8c3ed

mik-tf added 4 commits 2026-02-14 04:43:00 +00:00

fix: align all ports with hero_ports registry and add hero_launcher ... 5c8cc35837

- Fix stale ports across docs, tests, examples, CI, Dockerfile, Makefile
- Replace 6666→3378 (hero_redis), 7365→3387 (hero_forge), 8080→3390
  (hero_supervisor), 6379→3378 (hero_redis), 3030→N/A (removed)
- Add hero_launcher (3394) to DEFAULT_CONFIGS in config.rs
- Rewrite buildenv.sh with all correct port assignments
- Update SERVICE_ARCHITECTURE.md with complete service table
- Fix CI workflow docker-run port mappings
- Fix Dockerfile EXPOSE ports

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: disable hero_redis web UI to prevent template conflict crash ... 260c628afb

hero_redis's embedded admin UI (--web-port 2759) scans the current
working directory for template files. When launched by zinit under
hero_zero's directory, it finds hero_zero's admin UI templates which
are incompatible, causing a parse error and immediate exit.

Adding --web-port 0 disables the web UI, fixing the crash. The admin
UI can be re-enabled once hero_redis properly embeds its templates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: standardize Makefile per makefile_helper skill conventions ... b93e27d5fa

- Add standard targets: help, version, status, installdev, test-all, all
- Move config variables to top (VERSION, BINARY_NAME, INSTALL_DIR, etc.)
- Use self-documenting help with grep pattern
- Merge check and clippy into single fmt target
- Add scripts/test-all.sh for CI-equivalent local validation
- Organize sections per skill template
- Fix run target description (was misleading "from releases")

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

refactor: extract Makefile logic into scripts per makefile_helper skill ... 76da43af35

Makefile targets must be 1-2 commands max with no inline scripting.

- dev target (4 lines) → scripts/dev.sh
- install target (3 lines) → scripts/install.sh
- installdev now 2 lines (build + install.sh)
- fmt split into 2 separate lines (was chained with &&)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf changed title from fix: standardize hero_os port to 8880 to fix: port standardization, Makefile cleanup, and service fixes 2026-02-14 04:43:54 +00:00

mik-tf added 1 commit 2026-02-14 04:50:34 +00:00

fix: use registry image for hero_launcher Docker runtime ... bf08c0d335

Point hero_launcher at forge.ourworld.tf/lhumina_code/hero_zero:latest
so container creation doesn't fail looking for a local-only image.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-14 14:38:00 +00:00

fix: keep process alive when admin UI is disabled ... 497a587685

When --admin-port 0 is passed, hero_zero now blocks on ctrl_c/SIGTERM
instead of exiting. This keeps zinit child services running inside
Docker containers where the admin UI port may conflict with the host.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf closed this pull request 2026-02-16 00:50:07 +00:00

mik-tf referenced this pull request 2026-02-16 00:51:00 +00:00

fix: ports, Makefile, tests, secrets, and dependency cleanup #14

Some checks failed

Hide all checks

Build and Test / build (pull_request) Failing after 33s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_services!13

No description provided.