Collapse catalog to a meta-service for managing Hero services (#1) #3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-1-meta-service"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1.
Summary
ServiceDefinitioncollapses from a parallelServiceToml(binaries,sockets,category,status,version, …) to{ name, description, interfaces: [Interface] }—sid/created_at/updated_atare auto-injected (hero_rpc#85), and the redeclaredKind/Category/Protocol/SockType/Binary/Socket/ServiceMetatypes are gone (live service metadata is read from each service's ownservice.toml). Closes hero_rpc#72.service ServiceCatalogexposes:list/get_by_name/list_by_interface— real, backed byOsisCatalog.bootstrap(name, description, interfaces) → OpReport— mocked; real wiring →hero_rpc_osis::build::OschemaBuilder+ canonical service template fromhero_skills.refactor(name, prompt) → OpReport— mocked; real wiring →herolib_ai::AiClient::from_env()with skill bodies as system prompt.check(name) → OpReport— mocked; real wiring → rule packs fromhero_skills/skills/*(service.toml, sockets, branching, naming, layout).verify(name) → OpReport— mocked; real wiring →cargo build+--info --jsonparse + socket connect +tests_smoketest.OpReportwith aTODO[<op>]block incrates/hero_service_server/src/catalog/rpc.rsnaming the exact crate / skill the production version will pull.Refs
sidfield.sid/created_at/updated_at.Test plan
cargo build --workspace— clean.cargo test --workspace— clean (2 catalog CRUD tests pass).`hero_service` is the canonical template *and* the seed of the meta-service that bootstraps, refactors, checks and verifies other Hero services. This commit rewrites the catalog domain so it actually looks like that service — its OSchema, its RPC surface, and its handler stubs all line up with the "manage hero services" framing. `ServiceDefinition` collapses from a parallel `ServiceToml` (binaries, sockets, category, status, version, …) to the minimum the catalog needs: ServiceDefinition = { name: str @index description: str interfaces: [Interface] } `sid` / `created_at` / `updated_at` are no longer declared in the schema — they are auto-injected by the generator (hero_rpc#85). All redeclared ServiceToml types (Kind / Category / Protocol / SockType / Binary / Socket / ServiceMeta) are gone; live service metadata is read from each service's own `service.toml` via `herolib_core::base::ServiceToml`. Closes hero_rpc#72. `Interface` (server | admin | cli | web | rhai), `OpStatus`, `Diagnostic` and `OpReport` are added — owned by the catalog, used by the meta-ops below. `service ServiceCatalog` now exposes: - list / get_by_name / list_by_interface — queries - bootstrap(name, description, interfaces) → OpReport - refactor(name, prompt) → OpReport - check(name) → OpReport - verify(name) → OpReport The four meta-ops are **mocked** — each returns a realistic canned `OpReport` and a single `TODO[<op>]` comment naming the exact crate / skill that the production implementation will pull: | op | production wiring | |-----------|----------------------------------------------------------------| | bootstrap | `hero_rpc_osis::build::{OschemaBuildConfig, OschemaBuilder}` + canonical service template from hero_skills | | refactor | `herolib_ai::AiClient::from_env()` with skill bodies as system prompt | | check | rule packs from hero_skills (service.toml, sockets, branching, naming, layout) | | verify | cargo build + `<binary> --info --json` + socket connect + tests_smoketest | Queries (`list`, `get_by_name`, `list_by_interface`) are real — they hit the OSIS-backed `OsisCatalog` domain. - `crates/hero_service/build.rs`: drop the removed `.docs_dir(...)` builder call (the new generator emits canonical `docs/openrpc.json`). - `crates/hero_service/src/services/`: removed — was an empty placeholder module; meta-op handlers live in `hero_service_server` where handlers belong. `hero_rpc` deps point at branch `issue-85-rootobj-sid-validation`. Without that fix, the generator rejects `ServiceDefinition` because it has no explicit `sid` field, even though the Rust struct emitter auto-injects it. Switch the three Cargo.toml files back to `branch = "development"` once hero_rpc#85 is merged. - Closes hero_rpc#72 (no service redeclares `herolib_core::base` types). - Blocks on hero_rpc#85 (`fix(generator): drop redundant sid-field requirement on root objects`). - Drives hero_skills#275 (skill change to stop telling authors to declare `sid` / `created_at` / `updated_at`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>Closing — equivalent content was already squash-merged via #2 onto development (commit
8c0df0f). Will open a small follow-up PR for the leftover cleanup (drop the now-stale TEMPORARY hero_rpc#85 comments).Pull request closed