terminal works but not good enough #9

New issue

Closed

opened 2026-03-18 08:24:09 +00:00 by despiegk · 4 comments

despiegk commented 2026-03-18 08:24:09 +00:00

Owner

Copy link

need colors
also need to make sure mouse can be used? is send to terminal

also the dropdown doesn't work properly to select job which us running

also need right mouse on job, to get terminal

also need route so its terminal/$jobid...

os we can right away jump to it

 need colors also need to make sure mouse can be used? is send to terminal also the dropdown doesn't work properly to select job which us running also need right mouse on job, to get terminal also need route so its terminal/$jobid... os we can right away jump to it

image.png

1.6 MiB

despiegk commented 2026-03-18 09:55:05 +00:00

Author

Owner

Copy link

not good

 not good

image.png

260 KiB

despiegk commented 2026-03-18 10:00:04 +00:00

Author

Owner

Copy link

Implementation Spec for Issue #9 — Terminal Improvements

Objective

Improve the terminal tab in the HeroProc dashboard to provide full color support, mouse input forwarding, a working job selector dropdown, right-click "Open Terminal" on jobs, and deep-link routing via #terminal/{jobid}.

Root Causes Found

1. No color: PTY executor doesn't set TERM=xterm-256color — programs default to dumb terminal
2. No mouse: _term.onBinary() not wired up — xterm.js needs it for mouse escape sequences
3. Dropdown broken: populatePtyServiceList() calls service.list and iterates with Object.keys() incorrectly
4. No right-click terminal: Context menus don't include "Open Terminal"
5. No deep-link routing: No #terminal/... hash route support

Files to Modify

• crates/hero_proc_server/src/supervisor/executor.rs — Set TERM/COLORTERM env vars for PTY jobs
• crates/hero_proc_server/src/web.rs — Add /api/jobs/{id}/pty WebSocket endpoint
• crates/hero_proc_ui/src/routes.rs — Add job PTY proxy route + terminal SPA route
• crates/hero_proc_ui/templates/index.html — Fix terminal tab: dropdown, mouse, deep-link
• crates/hero_proc_ui/static/js/dashboard.js — Terminal routing, context menu items
• crates/hero_proc_ui/static/css/dashboard.css — Terminal container sizing

Implementation Plan

Step 1: Set TERM env vars (server) — no deps

Set TERM=xterm-256color and COLORTERM=truecolor in executor.rs for PTY jobs.

Step 2: Add job-based PTY endpoint (server) — no deps

New route /api/jobs/{id}/pty that looks up PTY handle by job_id directly.

Step 3: Add job PTY proxy route (UI) — depends on Step 2

Proxy /api/jobs/{id}/pty WebSocket to server, add /terminal/{rest} SPA route.

Step 4: Fix terminal tab JS (UI) — depends on Step 3

Rewrite dropdown to list running jobs, fix attach to use job-based endpoint, add onBinary for mouse.

Step 5: Terminal deep-link routing (UI) — depends on Step 4

Handle #terminal/{jobId} in hashchange, auto-attach on navigation.

Step 6: "Open Terminal" context menus (UI) — depends on Step 4

Add Terminal option to job/service right-click menus.

Step 7: CSS adjustments — no deps

Ensure terminal container fills space properly.

Acceptance Criteria

• PTY jobs show full color output (256-color + truecolor)
• Mouse input works in terminal apps (htop, vim)
• Dropdown lists running jobs (not services), shows job ID + action
• Right-click on running job shows "Open Terminal"
• #terminal/42 deep-links to job 42's terminal
• URL updates to #terminal/{jobId} when attached

## Implementation Spec for Issue #9 — Terminal Improvements ### Objective Improve the terminal tab in the HeroProc dashboard to provide full color support, mouse input forwarding, a working job selector dropdown, right-click "Open Terminal" on jobs, and deep-link routing via `#terminal/{jobid}`. ### Root Causes Found 1. **No color**: PTY executor doesn't set `TERM=xterm-256color` — programs default to dumb terminal 2. **No mouse**: `_term.onBinary()` not wired up — xterm.js needs it for mouse escape sequences 3. **Dropdown broken**: `populatePtyServiceList()` calls `service.list` and iterates with `Object.keys()` incorrectly 4. **No right-click terminal**: Context menus don't include "Open Terminal" 5. **No deep-link routing**: No `#terminal/...` hash route support ### Files to Modify - `crates/hero_proc_server/src/supervisor/executor.rs` — Set TERM/COLORTERM env vars for PTY jobs - `crates/hero_proc_server/src/web.rs` — Add `/api/jobs/{id}/pty` WebSocket endpoint - `crates/hero_proc_ui/src/routes.rs` — Add job PTY proxy route + terminal SPA route - `crates/hero_proc_ui/templates/index.html` — Fix terminal tab: dropdown, mouse, deep-link - `crates/hero_proc_ui/static/js/dashboard.js` — Terminal routing, context menu items - `crates/hero_proc_ui/static/css/dashboard.css` — Terminal container sizing ### Implementation Plan #### Step 1: Set TERM env vars (server) — no deps Set `TERM=xterm-256color` and `COLORTERM=truecolor` in `executor.rs` for PTY jobs. #### Step 2: Add job-based PTY endpoint (server) — no deps New route `/api/jobs/{id}/pty` that looks up PTY handle by job_id directly. #### Step 3: Add job PTY proxy route (UI) — depends on Step 2 Proxy `/api/jobs/{id}/pty` WebSocket to server, add `/terminal/{rest}` SPA route. #### Step 4: Fix terminal tab JS (UI) — depends on Step 3 Rewrite dropdown to list running jobs, fix attach to use job-based endpoint, add `onBinary` for mouse. #### Step 5: Terminal deep-link routing (UI) — depends on Step 4 Handle `#terminal/{jobId}` in hashchange, auto-attach on navigation. #### Step 6: "Open Terminal" context menus (UI) — depends on Step 4 Add Terminal option to job/service right-click menus. #### Step 7: CSS adjustments — no deps Ensure terminal container fills space properly. ### Acceptance Criteria - [ ] PTY jobs show full color output (256-color + truecolor) - [ ] Mouse input works in terminal apps (htop, vim) - [ ] Dropdown lists running jobs (not services), shows job ID + action - [ ] Right-click on running job shows "Open Terminal" - [ ] `#terminal/42` deep-links to job 42's terminal - [ ] URL updates to `#terminal/{jobId}` when attached

despiegk commented 2026-03-18 10:13:49 +00:00

Author

Owner

Copy link

Implementation Complete — Terminal Improvements

Changes Made

Server (hero_proc_server)

• executor.rs — Set TERM=xterm-256color and COLORTERM=truecolor env vars for PTY jobs (enables color output)
• web.rs — Added /api/jobs/{id}/pty WebSocket endpoint for direct job-based PTY attach

UI Proxy (hero_proc_ui)

• routes.rs — Added /api/jobs/{id}/pty proxy route + /terminal/{rest} SPA route

Frontend

• index.html — Rewrote terminal tab: job-based dropdown, attachToJob(), mouse support via onBinary
• dashboard.js — Added #terminal/{jobId} deep-link routing, "Open Terminal" in right-click context menus
• dashboard.css — Terminal container flex layout for proper sizing

Test Results

• hero_proc_server: 55 passed, 0 failed
• hero_proc_ui: compiles clean (no unit tests)
• Integration tests: 102 passed, 3 pre-existing failures (unrelated CLI help tests)

Acceptance Criteria Status

• PTY jobs set TERM=xterm-256color for color support
• Mouse input forwarded via onBinary handler
• Dropdown lists running jobs (not services)
• Right-click on job shows "Open Terminal"
• #terminal/{jobId} deep-link routing works
• URL updates when attaching to a job

## Implementation Complete — Terminal Improvements ### Changes Made **Server (`hero_proc_server`)** - `executor.rs` — Set `TERM=xterm-256color` and `COLORTERM=truecolor` env vars for PTY jobs (enables color output) - `web.rs` — Added `/api/jobs/{id}/pty` WebSocket endpoint for direct job-based PTY attach **UI Proxy (`hero_proc_ui`)** - `routes.rs` — Added `/api/jobs/{id}/pty` proxy route + `/terminal/{rest}` SPA route **Frontend** - `index.html` — Rewrote terminal tab: job-based dropdown, `attachToJob()`, mouse support via `onBinary` - `dashboard.js` — Added `#terminal/{jobId}` deep-link routing, "Open Terminal" in right-click context menus - `dashboard.css` — Terminal container flex layout for proper sizing ### Test Results - `hero_proc_server`: **55 passed**, 0 failed - `hero_proc_ui`: compiles clean (no unit tests) - Integration tests: **102 passed**, 3 pre-existing failures (unrelated CLI help tests) ### Acceptance Criteria Status - [x] PTY jobs set TERM=xterm-256color for color support - [x] Mouse input forwarded via onBinary handler - [x] Dropdown lists running jobs (not services) - [x] Right-click on job shows "Open Terminal" - [x] `#terminal/{jobId}` deep-link routing works - [x] URL updates when attaching to a job

despiegk commented 2026-03-18 10:15:08 +00:00

Author

Owner

Copy link

Implementation committed: c88c7b4

Browse: c88c7b4

Implementation committed: `c88c7b4` Browse: https://forge.ourworld.tf/lhumina_code/hero_proc/commit/c88c7b4

despiegk referenced this issue from a commit 2026-03-18 10:24:15 +00:00

feat(terminal): improve terminal with colors, mouse, routing, and context menus

despiegk closed this issue 2026-03-18 14:35:04 +00:00

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

development

development_kristof_ttyd

main

development_home27

development_dioxus_bootstrap

fix/system-config-startup

development_mik_6_1

development_tty2

development_kristof

v0.4.0

archive/development_tty

v0.1.3

v0.1.2

v0.1.1

v0.1.0

v0.0.1-rc1

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_proc#9

No description provided.