chore: post-audit cleanup bundle (#43) #45

Merged

timur merged 1 commit from issue-43-audit-cleanup into main

2026-05-20 06:58:51 +00:00

timur commented

2026-05-20 06:57:21 +00:00

Owner

Closes #43.

Bundled sweep of the 7 independent §2-audit follow-ups (B1/B2/B4/B5/B7/B8/B10) — one commit, one PR per the issue's preference.

What changed

B1 — added canonical .forgejo/workflows/lab-publish.yaml (copied verbatim from hero_proc; auto-publishes musl-x86_64 to latest release on push to development + on v* tags). Kept existing build-linux.yaml.
B2 — git rm -r src/ to delete the stale duplicate generated files at the repo root (leftover from commit 4158f97 crate split; not referenced by any Cargo.toml).
B4 — PURPOSE.md now uses lab service hero_logic (not the logic alias) to match hero_proc style and lab's hardcoded SERVICE_MAP keying.
B5 — added minimal README.md pointing at PURPOSE.md and listing the lab service hero_logic lifecycle commands.
B7 — added [workspace.lints.clippy] allow block (mirrors hero_proc); silenced the 8 unused-code warnings with #[allow(dead_code)] on staged-but-not-yet-wired handlers + 2 unread backend_online template fields. Keeps the code around for upcoming UI work without warning.
B8 — set [workspace.package].version = "0.1.0"; switched all 4 crates to version.workspace = true.
B10 — dropped features = ["inspector"] from hero_logic_server's hero_rpc_server dep. The inspector HTML at GET / on rpc.sock is dead weight; admin already serves a richer UI on admin.sock via hero_admin_lib. Saves rust-embed + mime_guess from the server's tree (visible in Cargo.lock diff).

Out of scope

B3 (lab SERVICE_MAP — hero_skills), B6 (hero_logic_examples crate), §3 OSchema upgrade — separate follow-ups.

Acceptance

$ cargo build --workspace
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.23s

$ lab infocheck
repo: /private/tmp/hero_logic_43
crates discovered: 3
  ok   /private/tmp/hero_logic_43/crates/hero_logic
  ok   /private/tmp/hero_logic_43/crates/hero_logic_admin
  ok   /private/tmp/hero_logic_43/crates/hero_logic_server
summary: 3 crate(s) clean, 0 crate(s) with issues, 0 finding(s) total

Closes #43. Bundled sweep of the 7 independent §2-audit follow-ups (B1/B2/B4/B5/B7/B8/B10) — one commit, one PR per the issue's preference. ## What changed - **B1** — added canonical `.forgejo/workflows/lab-publish.yaml` (copied verbatim from hero_proc; auto-publishes musl-x86_64 to `latest` release on push to development + on `v*` tags). Kept existing `build-linux.yaml`. - **B2** — `git rm -r src/` to delete the stale duplicate generated files at the repo root (leftover from commit 4158f97 crate split; not referenced by any Cargo.toml). - **B4** — PURPOSE.md now uses `lab service hero_logic` (not the `logic` alias) to match hero_proc style and lab's hardcoded SERVICE_MAP keying. - **B5** — added minimal README.md pointing at PURPOSE.md and listing the `lab service hero_logic` lifecycle commands. - **B7** — added `[workspace.lints.clippy]` allow block (mirrors hero_proc); silenced the 8 unused-code warnings with `#[allow(dead_code)]` on staged-but-not-yet-wired handlers + 2 unread `backend_online` template fields. Keeps the code around for upcoming UI work without warning. - **B8** — set `[workspace.package].version = "0.1.0"`; switched all 4 crates to `version.workspace = true`. - **B10** — dropped `features = ["inspector"]` from `hero_logic_server`'s `hero_rpc_server` dep. The inspector HTML at `GET /` on `rpc.sock` is dead weight; admin already serves a richer UI on `admin.sock` via `hero_admin_lib`. Saves `rust-embed` + `mime_guess` from the server's tree (visible in Cargo.lock diff). ## Out of scope B3 (lab SERVICE_MAP — hero_skills), B6 (hero_logic_examples crate), §3 OSchema upgrade — separate follow-ups. ## Acceptance ``` $ cargo build --workspace Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.23s $ lab infocheck repo: /private/tmp/hero_logic_43 crates discovered: 3 ok /private/tmp/hero_logic_43/crates/hero_logic ok /private/tmp/hero_logic_43/crates/hero_logic_admin ok /private/tmp/hero_logic_43/crates/hero_logic_server summary: 3 crate(s) clean, 0 crate(s) with issues, 0 finding(s) total ```

timur added 1 commit

2026-05-20 06:57:21 +00:00

chore: post-audit cleanup bundle (#43 ) 2f79912a4d

Sweep of independent §2-audit follow-ups against `main`:

- B1: add canonical `.forgejo/workflows/lab-publish.yaml` (copy from
  hero_proc verbatim — publishes musl-x86_64 to `latest` release on
  push to development + on v* tags). Keep existing `build-linux.yaml`.
- B2: `git rm -r src/` — stale duplicate generated files at repo root,
  leftover from 4158f97 crate split, not referenced by any Cargo.toml.
- B4: PURPOSE.md uses `lab service hero_logic` (not the `logic` alias)
  to match hero_proc style + lab's hardcoded SERVICE_MAP keying.
- B5: add minimal README.md pointing to PURPOSE.md + listing the
  `lab service hero_logic` lifecycle commands.
- B7: add `[workspace.lints.clippy]` allow block (mirrors hero_proc);
  silence the 8 unused-code warnings with `#[allow(dead_code)]` on
  staged-but-not-yet-wired handlers (play_detail_handler,
  pretty_json_or_string, build_node_preview, fetch_referenced_actions,
  build_graph_and_panel, rpc_call) + 2 unread `backend_online` template
  fields. Keeps the code available for upcoming UI work without warning.
- B8: set `[workspace.package].version = "0.1.0"`; switch all 4 crates
  to `version.workspace = true`.
- B10: drop `features = ["inspector"]` from hero_logic_server's
  hero_rpc_server dep. Inspector HTML at GET / on rpc.sock is dead
  weight — admin already serves a richer UI on admin.sock via
  hero_admin_lib's `<hero-api-docs>` embed. Saves rust-embed +
  mime_guess from the server's tree (visible in Cargo.lock diff).

Out of scope (separate follow-ups): B3 lab SERVICE_MAP (hero_skills),
B6 hero_logic_examples crate, §3 OSchema upgrade.

Acceptance:
- `cargo build --workspace`: clean, 0 warnings
- `lab infocheck`: 3 crates clean, 0 findings

timur referenced this pull request

2026-05-20 06:57:35 +00:00

Post-audit cleanup: stale src/, canonical CI, README, lints, version, inspector feature #43

timur merged commit deb645d2ce into main

2026-05-20 06:58:51 +00:00

timur referenced this pull request from a commit

2026-05-20 06:58:53 +00:00

chore: post-audit cleanup bundle (#43) (#45)