build_lib.sh fails — missing buildenv.sh in hero_lib_rha #4

New issue

Open

opened 2026-03-31 08:41:40 +00:00 by mahmoud · 2 comments

mahmoud commented

2026-03-31 08:41:40 +00:00

Owner

Description:

Running ./scripts/build_lib.sh (or any Makefile target that sources it) fails because buildenv.sh does not exist at the repository root.

Error:

  ERROR: build_lib.sh: buildenv.sh not found at                                                                     
  /Users/mahmoud/code/forge.ourworld.tf/lhumina_code/hero_lib_rhai/buildenv.sh                                      
  ERROR: build_lib.sh: PROJECT_NAME not set after sourcing buildenv.sh                                              
  ERROR: build_lib.sh: BINARIES not set in buildenv.sh                                                            
  ERROR: build_lib.sh: ALL_FEATURES not set in buildenv.sh

Description: Running ./scripts/build_lib.sh (or any Makefile target that sources it) fails because buildenv.sh does not exist at the repository root. Error: ``` ERROR: build_lib.sh: buildenv.sh not found at /Users/mahmoud/code/forge.ourworld.tf/lhumina_code/hero_lib_rhai/buildenv.sh ERROR: build_lib.sh: PROJECT_NAME not set after sourcing buildenv.sh ERROR: build_lib.sh: BINARIES not set in buildenv.sh ERROR: build_lib.sh: ALL_FEATURES not set in buildenv.sh ```

despiegk commented

2026-04-05 17:42:24 +00:00

Owner

Implementation Spec for Issue #4

Objective

scripts/build_lib.sh is a shared library sourced in both this repo and external consumer repos (e.g. hero_lib_rhai). When sourced in a repo that does not have a buildenv.sh, the script currently fails hard with fatal errors and return 1, aborting sourcing entirely.

The fix: make the script gracefully degrade when buildenv.sh is absent — sourcing should succeed, all utility functions remain available, and any individual function that strictly requires a missing variable will fail at call time with a clear message rather than at source time.

Root Cause

Lines 63–92 of scripts/build_lib.sh contain three sequential hard-fail guards executed at source time:

# Hard fail if buildenv.sh absent
if [ -z "${PROJECT_NAME:-}" ]; then
    if [ -f "$REPO_SOURCE/buildenv.sh" ]; then
        source "$REPO_SOURCE/buildenv.sh" || return 1
    else
        echo "ERROR: buildenv.sh not found" >&2
        return 1   # kills sourcing
    fi
fi

# Hard fail if variables missing
if [ -z "${PROJECT_NAME:-}" ]; then ... return 1; fi
if [ -z "${BINARIES:-}" ];     then ... return 1; fi
if [ -z "${ALL_FEATURES:-}" ]; then ... return 1; fi

Fix (3 changes to `scripts/build_lib.sh`)

Change 1 — Soft warn instead of hard fail when buildenv.sh absent

Replace the return 1 with an INFO: message:

# before:
echo "ERROR: build_lib.sh: buildenv.sh not found at $REPO_SOURCE/buildenv.sh" >&2
return 1

# after:
echo "INFO: build_lib.sh: buildenv.sh not found at $REPO_SOURCE/buildenv.sh — skipping auto-config" >&2

Change 2 — Remove source-time mandatory variable validation

Remove the three return 1 guards for PROJECT_NAME, BINARIES, ALL_FEATURES from top-level scope. All functions that use these variables already validate them at call time.

Change 3 — Guard FORGE_PACKAGE_NAME default on PROJECT_NAME

# before:
FORGE_PACKAGE_NAME="${FORGE_PACKAGE_NAME:-$PROJECT_NAME}"

# after:
[ -n "${PROJECT_NAME:-}" ] && FORGE_PACKAGE_NAME="${FORGE_PACKAGE_NAME:-$PROJECT_NAME}"

Acceptance Criteria

source scripts/build_lib.sh in a repo with no buildenv.sh exits with status 0
All functions (build_binaries, verify_binaries, etc.) are defined after sourcing
Existing behavior in hero_lib (with buildenv.sh) is unchanged
Functions needing unset variables fail at call time with clear errors

## Implementation Spec for Issue #4 ### Objective `scripts/build_lib.sh` is a shared library sourced in both this repo and external consumer repos (e.g. `hero_lib_rhai`). When sourced in a repo that does **not** have a `buildenv.sh`, the script currently fails hard with fatal errors and `return 1`, aborting sourcing entirely. The fix: make the script **gracefully degrade** when `buildenv.sh` is absent — sourcing should succeed, all utility functions remain available, and any individual function that strictly requires a missing variable will fail at call time with a clear message rather than at source time. --- ### Root Cause Lines 63–92 of `scripts/build_lib.sh` contain three sequential hard-fail guards executed at **source time**: ``` # Hard fail if buildenv.sh absent if [ -z "${PROJECT_NAME:-}" ]; then if [ -f "$REPO_SOURCE/buildenv.sh" ]; then source "$REPO_SOURCE/buildenv.sh" || return 1 else echo "ERROR: buildenv.sh not found" >&2 return 1 # kills sourcing fi fi # Hard fail if variables missing if [ -z "${PROJECT_NAME:-}" ]; then ... return 1; fi if [ -z "${BINARIES:-}" ]; then ... return 1; fi if [ -z "${ALL_FEATURES:-}" ]; then ... return 1; fi ``` --- ### Fix (3 changes to `scripts/build_lib.sh`) #### Change 1 — Soft warn instead of hard fail when buildenv.sh absent Replace the `return 1` with an `INFO:` message: ```bash # before: echo "ERROR: build_lib.sh: buildenv.sh not found at $REPO_SOURCE/buildenv.sh" >&2 return 1 # after: echo "INFO: build_lib.sh: buildenv.sh not found at $REPO_SOURCE/buildenv.sh — skipping auto-config" >&2 ``` #### Change 2 — Remove source-time mandatory variable validation Remove the three `return 1` guards for `PROJECT_NAME`, `BINARIES`, `ALL_FEATURES` from top-level scope. All functions that use these variables already validate them at call time. #### Change 3 — Guard FORGE_PACKAGE_NAME default on PROJECT_NAME ```bash # before: FORGE_PACKAGE_NAME="${FORGE_PACKAGE_NAME:-$PROJECT_NAME}" # after: [ -n "${PROJECT_NAME:-}" ] && FORGE_PACKAGE_NAME="${FORGE_PACKAGE_NAME:-$PROJECT_NAME}" ``` --- ### Acceptance Criteria - [ ] `source scripts/build_lib.sh` in a repo with no `buildenv.sh` exits with status `0` - [ ] All functions (`build_binaries`, `verify_binaries`, etc.) are defined after sourcing - [ ] Existing behavior in `hero_lib` (with `buildenv.sh`) is unchanged - [ ] Functions needing unset variables fail at call time with clear errors

despiegk commented

2026-04-06 05:17:37 +00:00

Owner

Test Results

Ran make check on hero_lib after applying the fix.

Status: PASS
Details: cargo check --workspace completed successfully with Finished status. Two minor dead-code warnings were present (non-blocking):
1. crates/os/src/rootfs/distros/alpine.rs — command_exists method never used
2. crates/webserver/src/server.rs — extra_addrs field never read

No errors. All workspace crates checked successfully.

## Test Results Ran `make check` on hero_lib after applying the fix. - Status: PASS - Details: `cargo check --workspace` completed successfully with `Finished` status. Two minor dead-code warnings were present (non-blocking): 1. `crates/os/src/rootfs/distros/alpine.rs` — `command_exists` method never used 2. `crates/webserver/src/server.rs` — `extra_addrs` field never read No errors. All workspace crates checked successfully.