development_features #111

Open

timur wants to merge 30 commits from development_features into development

pull from: development_features

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:develop

lhumina_code:development_podman_sal

lhumina_code:development_rootfs

lhumina_code:develop_kernel_module

lhumina_code:main

Conversation 0 Commits 30 Files changed 1581 +9222 -10621

timur commented 2026-02-24 00:59:56 +00:00

Owner

Copy link

Branch Status Update

Cleaned up crates/inspector/ and crates/rpc/ from this branch — both have been moved to their own repositories:

• inspector → hero_inspector
• rpc → hero_rpc

This removes ~12,600 lines / 68 files from the diff.

What's still in this branch

Structural refactors:

• packages/ → crates/ directory rename (~344 files are pure moves, ~57 have small path fixups)
• herodo → hero_do rename + main.rs rewrite (1718 → 293 lines, drops the interactive REPL)
• Rhai feature made optional across all crates

New features:

• crates/clients_hero_os/ — extracts hero_embedder into its own Hero OS client crate (~4,900 lines)
• crates/code/ — Rhai bindings for the code parser + examples (~935 lines)
• crates/osis/rust_client.rs — generator rewrite/expansion (525 → 1,517 lines)

Minor:

• Docs, CI scripts, AI prompts updated for packages/ → crates/ paths
• Cargo.toml dependency tweaks across ~7 crates
• hero_rpc git dependencies added to workspace

Before merging

• The packages/ → crates/ rename will conflict with anything on development touching files under packages/ — needs coordination
• packages/infra/ and packages/oserver/ are leftover on this branch — decide whether to move to crates/ or remove
• hero_do REPL removal is intentional (script-only execution going forward)

## Branch Status Update Cleaned up `crates/inspector/` and `crates/rpc/` from this branch — both have been moved to their own repositories: - **inspector** → [hero_inspector](https://forge.ourworld.tf/lhumina_code/hero_inspector) - **rpc** → [hero_rpc](https://forge.ourworld.tf/lhumina_code/hero_rpc) This removes ~12,600 lines / 68 files from the diff. ### What's still in this branch **Structural refactors:** - `packages/` → `crates/` directory rename (~344 files are pure moves, ~57 have small path fixups) - `herodo` → `hero_do` rename + `main.rs` rewrite (1718 → 293 lines, drops the interactive REPL) - Rhai feature made optional across all crates **New features:** - `crates/clients_hero_os/` — extracts `hero_embedder` into its own Hero OS client crate (~4,900 lines) - `crates/code/` — Rhai bindings for the code parser + examples (~935 lines) - `crates/osis/rust_client.rs` — generator rewrite/expansion (525 → 1,517 lines) **Minor:** - Docs, CI scripts, AI prompts updated for `packages/` → `crates/` paths - Cargo.toml dependency tweaks across ~7 crates - `hero_rpc` git dependencies added to workspace ### Before merging - The `packages/` → `crates/` rename will conflict with anything on `development` touching files under `packages/` — needs coordination - `packages/infra/` and `packages/oserver/` are leftover on this branch — decide whether to move to `crates/` or remove - `hero_do` REPL removal is intentional (script-only execution going forward)

timur added 30 commits 2026-02-24 00:59:56 +00:00

fix: use correct re-export path for ClientError in SDK generator ... d9b253bf47

The offline module re-exports ClientError at herolib_osis::offline::ClientError,
not herolib_osis::offline::transport::ClientError. This caused all generated
SDK clients to fail to compile.

Closes lhumina_code/hero_osis#6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

merge: resolve conflict keeping WASM RPC client code from PR branch e686ba8158

Make rhai feature optional across all packages to reduce default dependencies ... 4126fbd644

- Convert rhai from a default/required dependency to an optional feature in
  core, os, virt, mos, clients, vault, ai, and code packages
- Add default-features = false to workspace dependency declarations so
  downstream crates opt-in explicitly
- Propagate rhai feature flags to transitive internal dependencies
  (e.g. mos/rhai enables virt/rhai, os/rhai, core/rhai)
- Update rhai version to 1.23.6 consistently across packages
- Gate rhai module compilation behind #[cfg(feature = "rhai")]
- Ensure herodo still activates rhai for all packages it aggregates

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/development' into development_features 5075f9b96e

Merge remote-tracking branch 'origin/development_mik' into development_features c4b10bd861

Merge development and development_mik branches into development_features ... b5e1f76350

- Integrate git_core enhancements from development
- Add rust_client generator from development_mik
- Update profiling modules with rhai feature flag handling

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

refactor: rename packages/ to crates/ for consistency ... 6a194f3b69

- Align directory structure with conventional Rust workspace layout
- Update all Cargo.toml workspace member paths from packages/* to crates/*
- Update all documentation, examples, and script references
- Verify build works correctly with new structure

All cargo check and compilation tests pass with crates/ naming.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

refactor: remove hero_do interactive REPL shell ... c0046f0cc4

- Remove interactive shell (run_repl function and all related REPL infrastructure)
- Keep script execution modes:
  - Running single .rhai script files
  - Running all .rhai files in a directory (recursive)
  - Reading scripts from stdin with -i flag
- Remove REPL dependencies: rustyline, colored, dirs
- Simplify main.rs to ~200 lines focused on script execution
- Update description and keywords to reflect script runner vs interactive shell
- Binary now requires explicit file/directory argument or -i flag
- All functionality tested and builds successfully

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: move hero_embedder into new clients_hero_os crate ... 6bf9f909a6

Extracts the hero_embedder module from herolib_clients into a dedicated
herolib_clients_hero_os crate to separate Hero OS service clients from
general-purpose infrastructure clients.

- Add crates/clients_hero_os with hero_embedder module (OpenRPC client + Rhai bindings)
- Remove hero_embedder from crates/clients (lib.rs, rhai.rs, Cargo.toml)
- Register herolib_clients_hero_os in workspace Cargo.toml

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

refactor: rename herodo to hero_do and add Rhai shebangs ... 1ef0b913b4

- Rename crates/herodo to crates/hero_do for consistency with naming conventions
- Add #!/usr/bin/env rhai shebangs to all Rhai example and test scripts
- Reorganize crates/code examples into builder and codeparser subdirectories
- Add hero_do_code binary and Makefile/buildenv.sh build helpers for code crate
- Update documentation and add new parser module README

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

fix: use correct Axum catch-all route syntax ... 233b79ea61

Replace {*path} with /*path in static file routes. Axum requires catch-all parameters to use the /*path syntax without braces.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: load services concurrently with real-time SSE updates ... ca7d6bc079

- Pass SSE broadcaster to Scanner for real-time service discovery updates
- Probe all sockets and manual sources concurrently instead of sequentially
- Send ServiceAdded SSE events as each service is discovered
- UI navbar now updates incrementally instead of waiting for full scan
- Eliminates blocking delays during service discovery

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add detailed logging for service discovery debugging ... 7b93be50c2

Adds comprehensive logging at all stages of service discovery:
- Initial startup shows configuration (socket dir, timeouts, refresh interval)
- Socket scan shows number of sockets found
- Each service probe shows status icon, name, method count, and duration
- Total scan time displayed
- Manual sources refresh shows count and timing
- Background refresh loop logs each cycle

Status icons:
- ✓ Healthy
- ⏸ Inactive
- ⚡ Non-RPC
- ❌ Unhealthy

Helps identify slow probes and blocking operations.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add granular socket discovery logging ... ad56194b3d

- Log each socket file discovered
- Show count of skipped and non-socket files
- Log before probing each socket
- Show which socket is currently being probed
- Set log level to debug by default for inspector
- Write logs to stderr to avoid buffering

Makes it easy to identify:
- Which sockets are found
- Which sockets are skipped
- Which probe is taking too long

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: improve inspector startup feedback and initial scan notifications ... 5734f3fafd

- Add kill-port target to Makefile to automatically kill existing processes on port 7400 before running
- Make run target depend on kill-port to avoid "Address already in use" errors
- Send SSE Scan event after initial service discovery completes (previously only sent on periodic refresh)
- Print discovery completion summary with discovered services count and list to console
- Improves user experience by showing clear progress feedback during initial startup

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: use Unpoly polling for real-time sidebar updates ... a9d8effdc4

- Add up-poll="3s" to sidebar to automatically refresh every 3 seconds
- Add up-keep="true" to preserve form state during updates
- Replace manual DOMContentLoaded load with Unpoly's polling mechanism
- Services will now appear in UI within 3 seconds of discovery
- Polling provides fallback to SSE for reliable real-time updates

This ensures services appear in the UI even if discovery happens before
the page loads, by polling the sidebar fragment every 3 seconds instead
of relying solely on one-time initial load.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add fallback REST /openrpc.json endpoint discovery ... 5005490c73

- Update socket probe to try both JSON-RPC and REST endpoints
- First attempts rpc.discover JSON-RPC method (standard)
- Falls back to GET /openrpc.json if method not found (for hero_embedder_server)
- Now discovers services that expose OpenRPC via REST instead of JSON-RPC

This enables hero_embedder_server and similar services to be properly
discovered and shown as Healthy instead of Inactive.

Fixes: Services that expose /openrpc.json REST endpoint now show as discoverable

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

fix: explicitly load sidebar on page load to trigger Unpoly updates ... f7ce0df6fb

- Add DOMContentLoaded listener to explicitly load sidebar via up.reload()
- Ensures sidebar populates even if up-poll timing is delayed
- Sidebar still updates every 3s via polling + SSE for real-time changes

This fixes the issue where sidebar would show "Loading services..." indefinitely
instead of displaying discovered services once they were loaded.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

fix: use up.navigate to load sidebar after DOMContentLoaded ... 6459a42263

- Add JavaScript hook in base.html to load sidebar via up.navigate()
- Waits for page to load before initiating Unpoly navigation
- Ensures sidebar content loads properly with discovered services
- Keeps polling (up-poll) for continuous updates every 3s

This fixes the persistent "Loading services..." issue by ensuring Unpoly
properly loads the sidebar fragment on page load.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

fix: replace Unpoly with plain fetch for sidebar loading ... 7a2227436e

- Use fetch() + innerHTML to load sidebar directly from /fragments/sidebar
- Avoids Unpoly initialization issues
- Poll every 3 seconds using setInterval
- Sidebar now loads immediately on page load

This fixes the persistent "Loading services..." issue. The backend was
working correctly all along - 16 services were in the cache and the
sidebar endpoint returned them correctly. The issue was purely with
Unpoly's navigation not loading the content in the browser.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add service detail loading via fetch ... 1afb02d005

- Add loadServiceDetail() function to fetch service documentation
- Add attachServiceClickHandlers() to attach click listeners to service items
- Service clicks now load documentation in main panel without Unpoly
- Re-attach handlers after each sidebar reload

This allows users to click on services to view their OpenRPC documentation
and method details.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add direct routes for service documentation and markdown ... fee0d1b929

- Add /service/:id route for service detail HTML documentation
- Add /service/:id/markdown route for markdown documentation
- Both routes support direct URL access (e.g., http://localhost:7400/service/{id})
- Update JavaScript to use /service/:id instead of /fragments/service/:id
- Markdown endpoint returns proper text/markdown content type

This allows:
1. Clicking services in sidebar to load documentation
2. Direct URL access to service docs: /service/{id}
3. Direct markdown access: /service/{id}/markdown
4. Browser bookmarks and sharing of service documentation

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

fix: replace all Unpoly calls with fetch-based loading ... d3c64362fd

- Replace up.reload() with fetch() for sidebar reloads
- Replace up.navigate() with fetch() for service detail loading
- Fix initRemoveButtons to reload sidebar on remove
- Fix initAddSpecForm to reload sidebar and auto-select new service
- Fix SSE event handlers to use fetch for sidebar reload
- Removes dependency on Unpoly working properly

This fixes the "Could not find common target" error when clicking scan,
remove, or add spec buttons. All sidebar updates now use plain fetch().

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: support service titles in URLs (human-readable routes) ... 3567166fdf

- Add get_by_title() method to cache for title-based lookups
- Update service_detail_handler to accept both ID and title
- Update markdown_handler to accept both ID and title
- Routes now work with service names: /service/Hero%20Embedder%20Server%20API
- Falls back to ID lookup if title not found

Examples:
- /service/Hero%20Embedder%20Server%20API (via title)
- /service/aac03e5c-b9c5-503a-9373-bbbaff84985e (via ID)
- /service/Hero%20Embedder%20Server%20API/markdown (markdown by title)

Both formats work and are case-insensitive for titles.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add full page view for service details ... bd15c922ce

- Create service_page_handler for direct URL access (/service/{id})
- Returns complete HTML page with navbar, dark mode, and styling
- Includes Bootstrap 5.3.3 and dashboard CSS for proper theming
- service_detail_handler still returns fragment for sidebar loads
- Both ID and title-based URLs supported

This fixes direct URL access to services showing only raw fragment HTML
without proper page layout or dark mode styling. Now visiting
/service/{id} or /service/{title} displays a complete, styled page.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

refactor: remove ID-based URL support, use service names only ... 694a0b2662

- Update service_page_handler to only use get_by_title() for service lookups
- Update markdown_handler to only use get_by_title() for service lookups
- Removes ID fallback logic that was no longer needed
- All service URLs now use human-readable service names (titles)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add markdown documentation viewer with Bootstrap styling ... 7771c76a42

- Add pulldown-cmark crate for markdown-to-HTML conversion
- Create markdown_view_handler that renders markdown as styled HTML
- Add /service/:id/markdown/view route for viewing docs in browser
- Update service detail template with "View Documentation" button
- Add viewMarkdown() JavaScript function to open docs in new tab
- Style markdown content with Bootstrap classes, code blocks, tables, and blockquotes
- Provides readable, professional documentation viewing experience

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

fix: use service title instead of ID for sidebar click handlers ... 53b60ea6b8

- Update attachServiceClickHandlers() to use data-title instead of data-id
- Update loadServiceDetail() to encode service name properly in URL
- Fixes 'Service not found' error when clicking services in sidebar
- Service names are now correctly matched by title lookup

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add tabbed UI with syntax-highlighted OpenRPC, styled markdown, and copy buttons ... d6d63e5a90

Remove download buttons, add Markdown/OpenRPC tabs with copy-to-clipboard,
JSON syntax highlighting, and Bootstrap dark-mode styled markdown rendering.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chore: remove inspector and rpc crates (moved to own repos) ... a4df2bf92e

- crates/inspector/ moved to hero_inspector repo
- crates/rpc/ moved to hero_rpc repo
- Remove inspector from workspace members in Cargo.toml

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Some checks failed

Hide all checks

Lint / lint-linux (pull_request) Failing after 25s

Details

Tests with Services / test-linux (pull_request) Failing after 6m56s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin development_features:development_features

git switch development_features

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff development_features

git switch development_features

git rebase development

git switch development

git merge --ff-only development_features

git switch development_features

git rebase development

git switch development

git merge --no-ff development_features

git switch development

git merge --squash development_features

git switch development

git merge --ff-only development_features

git switch development

git merge development_features

git push origin development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_lib!111

No description provided.