lhumina_code/hero_lib
21
0
Fork 1
Code Issues 16 Pull requests 1 Projects Releases 2 Packages 1 Wiki Activity Actions

fix: correct ClientError re-export path in OSIS SDK generator #110

Closed
mik-tf wants to merge 0 commits from development_mik into development
pull from: development_mik
merge into: lhumina_code:development
Conversation 1 Commits - Files changed - +992
mik-tf commented 2026-02-19 02:59:28 +00:00
Owner
Copy link

Summary

  • Fix the SDK code generator to emit herolib_osis::offline::ClientError instead of herolib_osis::offline::transport::ClientError
  • The offline module re-exports ClientError directly; the transport sub-path does not exist in the public API
  • This is a 1-line fix in packages/osis/src/generators/rust/rust_client.rs

Closes #101
Relates to: lhumina_code/hero_osis#6

Consolidated from #100 into development_mik branch (includes latest development merged in).

## Summary - Fix the SDK code generator to emit `herolib_osis::offline::ClientError` instead of `herolib_osis::offline::transport::ClientError` - The `offline` module re-exports `ClientError` directly; the `transport` sub-path does not exist in the public API - This is a 1-line fix in `packages/osis/src/generators/rust/rust_client.rs` Closes #101 Relates to: https://forge.ourworld.tf/lhumina_code/hero_osis/issues/6 --- Consolidated from #100 into `development_mik` branch (includes latest `development` merged in).
fix: use correct re-export path for ClientError in SDK generator
Some checks failed
Lint / lint-linux (pull_request) Failing after 23s
Details
Tests with Services / test-linux (pull_request) Has been cancelled
Details
Lint / lint-macos (pull_request) Has been cancelled
Details
Tests with Services / test-macos (pull_request) Has been cancelled
Details
d9b253bf47 
The offline module re-exports ClientError at herolib_osis::offline::ClientError,
not herolib_osis::offline::transport::ClientError. This caused all generated
SDK clients to fail to compile.

Closes lhumina_code/hero_osis#6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
merge: resolve conflict keeping WASM RPC client code from PR branch
All checks were successful
Lint / lint-linux (pull_request) Successful in 2m31s
Details
Tests with Services / test-linux (pull_request) Successful in 15m10s
Details
e686ba8158
timur commented 2026-02-23 20:16:50 +00:00
Owner
Copy link

closing since offline functionality was removed and the rpc code generation moved to hero_rpc

closing since offline functionality was removed and the rpc code generation moved to `hero_rpc`
timur closed this pull request 2026-02-23 20:16:50 +00:00
All checks were successful
Lint / lint-linux (pull_request) Successful in 2m31s
Details
Tests with Services / test-linux (pull_request) Successful in 15m10s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_lib!110
No description provided.