standardize: naming, ports, and dependency conventions #31

Merged

mik-tf merged 4 commits from development_hero_zero_standardize into development 2026-02-12 00:55:36 +00:00

Conversation 0 Commits 4 Files changed 7 +55 -97

mik-tf commented 2026-02-11 23:40:16 +00:00

Owner

Copy link

Changes

Naming Convention (snake_case)

• Package: heroledger → hero_ledger
• Kept [lib] name = "heroledger" for backward compat (preserves 47 use heroledger:: imports)
• Binaries: heroledger → hero_ledger, heroledger-relayer → hero_ledger_relayer
• Dependencies: herolib-vault → herolib_vault, herolib-code → herolib_code, herolib-os → herolib_os
• Feature deps: dep:herolib-code → dep:herolib_code, dep:herolib-os → dep:herolib_os
• Git URLs updated from geomind_research/herolib_rust to lhumina_code/hero_lib

Ports

• buildenv.sh: PORTS "" → "3030 24567 9901" (per hero_ports registry)
• buildenv.sh: BINARIES updated to hero_ledger hero_ledger_relayer

Backward Compatibility (per naming_convention Section 7)

• Wire protocol strings unchanged
• Data directories (~/.heroledger/) unchanged
• Env vars (HEROLEDGER_*) unchanged
• [lib] name = "heroledger" preserves all existing use imports

Build passes.

## Changes ### Naming Convention (snake_case) - Package: `heroledger` → `hero_ledger` - Kept `[lib] name = "heroledger"` for backward compat (preserves 47 `use heroledger::` imports) - Binaries: `heroledger` → `hero_ledger`, `heroledger-relayer` → `hero_ledger_relayer` - Dependencies: `herolib-vault` → `herolib_vault`, `herolib-code` → `herolib_code`, `herolib-os` → `herolib_os` - Feature deps: `dep:herolib-code` → `dep:herolib_code`, `dep:herolib-os` → `dep:herolib_os` - Git URLs updated from `geomind_research/herolib_rust` to `lhumina_code/hero_lib` ### Ports - `buildenv.sh`: PORTS "" → "3030 24567 9901" (per hero_ports registry) - `buildenv.sh`: BINARIES updated to `hero_ledger hero_ledger_relayer` ### Backward Compatibility (per naming_convention Section 7) - Wire protocol strings unchanged - Data directories (~/.heroledger/) unchanged - Env vars (HEROLEDGER_*) unchanged - `[lib] name = "heroledger"` preserves all existing `use` imports **Build passes.**

mik-tf added 1 commit 2026-02-11 23:40:16 +00:00

standardize: rename package/binaries to snake_case, fix ports ... d61e1d9f43

- Cargo.toml: package name heroledger → hero_ledger
- Cargo.toml: binary heroledger → hero_ledger
- Cargo.toml: binary heroledger-relayer → hero_ledger_relayer
- Cargo.toml: keep [lib] name = "heroledger" for backward compat
  (preserves all 'use heroledger::' imports and wire protocol strings)
- buildenv.sh: BINARIES updated to hero_ledger hero_ledger_relayer
- buildenv.sh: PORTS "" → "3030 24567 9901" (per hero_ports registry)
- Makefile: all binary references updated to hero_ledger

Per naming_convention skill Section 7:
- Wire protocol strings unchanged (NEAR account IDs, chain IDs)
- Data directories unchanged (~/.heroledger/)
- Environment variables unchanged (HEROLEDGER_*)
- [lib] name preserved to avoid breaking internal imports

mik-tf added 1 commit 2026-02-11 23:56:36 +00:00

standardize: rename herolib-* deps to herolib_* (snake_case) ... b14ba69d93

- herolib-vault → herolib_vault
- herolib-code → herolib_code
- herolib-os → herolib_os
- Update git URLs from geomind_research/herolib_rust to lhumina_code/hero_lib
- Update feature deps: dep:herolib-code → dep:herolib_code, etc.

Per naming_convention skill: all package names use snake_case.

mik-tf changed title from Standardize: naming convention, ports, Makefile compliance to standardize: naming, ports, and dependency conventions 2026-02-12 00:00:56 +00:00

mik-tf added 1 commit 2026-02-12 00:11:09 +00:00

ci: restrict test triggers to PRs and push to development/main ... 4d623ed662

Stop triggering test/build workflows on every push to every branch.
Tests now run only on:
- push to development or main (post-merge validation)
- pull_request targeting development or main (pre-merge check)
- manual workflow_dispatch

Per forge_ci skill: Standard Workflow Triggers convention.

mik-tf added 1 commit 2026-02-12 00:45:58 +00:00

standardize: switch git dep branches to development ... 2af2889182

Preparation for merge: all git dependency branch refs changed from
development_hero_zero_standardize to development. After hero_lib PR
merges first, all downstream deps resolve on development branch.

mik-tf merged commit ccbfadc6e1 into development 2026-02-12 00:55:36 +00:00

mik-tf referenced this pull request from a commit 2026-02-12 00:55:37 +00:00

Merge pull request 'standardize: naming, ports, and dependency conventions' (#31) from development_hero_zero_standardize into development

mik-tf deleted branch development_hero_zero_standardize 2026-02-12 00:55:41 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

urgent

No labels

urgent

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_ledger!31

No description provided.