chore(hero_db): D-10 sweep — cargo update + conservative dep audit #31

Merged

mik-tf merged 1 commit from development_mik into development

2026-05-16 02:23:16 +00:00

mik-tf commented

2026-05-16 02:22:13 +00:00

Owner

Closes part of hero_proc#102 (T1 #3 deps-first; s98 in the workspace multi-session sweep).

D-10 acceptance — 5/5 met

#	Criterion	Status
1	`lab infocheck` exits 0	✓ `3 crate(s) clean, 0 finding(s) total` — first try
2	Canonical `main.rs` wiring on all 3 binaries	✓ already in place (`hero_db` repo is the reference impl that hero_proc#103 copied from)
3	`cargo update` clean	✓ `hero_proc_sdk` 76e76b5d → a436a20f (s97 PR #103 merge), `herolib_core` 37125e55 → 9b5912bf (s96 cascade), `hero_rpc` caa028ff → f17dcd71
4	`Cargo.toml` deps audited, AI-cruft stripped	✓ 7 zero-match deps removed (see below)
5	`lab service <bin> --install --start` + smoke	✓ `hero_db_server` smoke 4/4 passed (GET /health + GET /openrpc.json + GET /.well-known/heroservice.json + POST /rpc system.ping); `hero_db_admin` smoke 2/2 passed (GET /health + GET /.well-known/heroservice.json)

What

cargo update — picks up the s97 cascade

hero_proc_sdk     76e76b5d → a436a20f   (s97 PR #103 merge)
herolib_core      37125e55 → 9b5912bf   (s96 PR #140 cascade)
herolib_derive    37125e55 → 9b5912bf
hero_rpc_derive   caa028ff → f17dcd71
hero_rpc_openrpc  caa028ff → f17dcd71

Conservative dep audit (7 deps stripped)

Only deps with 0 use <dep>::|<dep>:: matches under src/ were stripped:

Crate	Deps removed
`hero_db_server`	`serde`, `libc`
`hero_db_admin`	`serde`, `hero_db_sdk`, `dirs`
`hero_db` (CLI)	`tracing-subscriber`, `dirs`

Note: hero_db_sdk was listed under [dependencies] in hero_db_admin/Cargo.toml but zero use hero_db_sdk / hero_db_sdk:: in src/ — admin proxies via direct hyper client to hero_db_server's rpc.sock, no SDK call sites. The dev-dep listing in hero_db_server (for integration tests under tests/) is preserved.

No source-level changes

service.toml already canonical at a08a1c4; main.rs wiring already complete on all 3 binaries. The full s98 diff is 4 files: 3 Cargo.toml + Cargo.lock (5 insertions(+), 21 deletions(-)).

Test impact

cargo test --workspace --release --no-fail-fast: 75 passed, 0 failed, 10 ignored. No regressions.

Signed-off-by: mik-tf

Closes part of [hero_proc#102](https://forge.ourworld.tf/lhumina_code/hero_proc/issues/102) (T1 #3 deps-first; s98 in the workspace multi-session sweep). ## D-10 acceptance — 5/5 met | # | Criterion | Status | |---|---|---| | 1 | `lab infocheck` exits 0 | ✓ `3 crate(s) clean, 0 finding(s) total` — **first try** | | 2 | Canonical `main.rs` wiring on all 3 binaries | ✓ already in place (`hero_db` repo is the reference impl that hero_proc#103 copied from) | | 3 | `cargo update` clean | ✓ `hero_proc_sdk` 76e76b5d → a436a20f (s97 PR #103 merge), `herolib_core` 37125e55 → 9b5912bf (s96 cascade), `hero_rpc` caa028ff → f17dcd71 | | 4 | `Cargo.toml` deps audited, AI-cruft stripped | ✓ 7 zero-match deps removed (see below) | | 5 | `lab service <bin> --install --start` + smoke | ✓ `hero_db_server` **smoke 4/4 passed** (GET /health + GET /openrpc.json + GET /.well-known/heroservice.json + POST /rpc system.ping); `hero_db_admin` **smoke 2/2 passed** (GET /health + GET /.well-known/heroservice.json) | ## What ### cargo update — picks up the s97 cascade ``` hero_proc_sdk 76e76b5d → a436a20f (s97 PR #103 merge) herolib_core 37125e55 → 9b5912bf (s96 PR #140 cascade) herolib_derive 37125e55 → 9b5912bf hero_rpc_derive caa028ff → f17dcd71 hero_rpc_openrpc caa028ff → f17dcd71 ``` ### Conservative dep audit (7 deps stripped) Only deps with 0 `use <dep>::|<dep>::` matches under `src/` were stripped: | Crate | Deps removed | |---|---| | `hero_db_server` | `serde`, `libc` | | `hero_db_admin` | `serde`, `hero_db_sdk`, `dirs` | | `hero_db` (CLI) | `tracing-subscriber`, `dirs` | Note: `hero_db_sdk` was listed under `[dependencies]` in `hero_db_admin/Cargo.toml` but zero `use hero_db_sdk` / `hero_db_sdk::` in `src/` — admin proxies via direct hyper client to `hero_db_server`'s rpc.sock, no SDK call sites. The dev-dep listing in `hero_db_server` (for integration tests under `tests/`) is preserved. ## No source-level changes `service.toml` already canonical at `a08a1c4`; `main.rs` wiring already complete on all 3 binaries. The full s98 diff is **4 files: 3 `Cargo.toml` + `Cargo.lock`** (`5 insertions(+), 21 deletions(-)`). ## Test impact `cargo test --workspace --release --no-fail-fast`: **75 passed, 0 failed, 10 ignored**. No regressions. --- Signed-off-by: mik-tf

mik-tf added 1 commit

2026-05-16 02:22:13 +00:00

chore(hero_db): D-10 sweep — cargo update + conservative dep audit

Build and Test / build (pull_request) Successful in 4m55s

Details

544c1a6243

Closes part of lhumina_code/hero_proc#102
(T1 #3 deps-first; s98 in the workspace multi-session sweep).

## What

- `cargo update` picks up the s97 cascade: `hero_proc_sdk` 76e76b5d →
  a436a20f (s97 PR #103 merge), `herolib_core` 37125e55 → 9b5912bf
  (s96 PR #140 cascade), `hero_rpc` caa028ff → f17dcd71.
- Strip 7 zero-match deps across the 3 binary crates (conservative
  audit; only deps with 0 hits under `src/`):
  - `hero_db_server`: `serde`, `libc`
  - `hero_db_admin`: `serde`, `hero_db_sdk`, `dirs`
  - `hero_db` (CLI): `tracing-subscriber`, `dirs`

`service.toml` already canonical at `a08a1c4` (this repo IS the
reference impl); `main.rs` wiring already in place on all 3 binaries
(`service_base!()` + `validate_service_toml` + `handle_info_flag` +
banner + sockets). Therefore no source-level changes needed beyond
the dep audit.

## D-10 acceptance (all 5 met)

1. `lab infocheck`: `3 crate(s) clean, 0 finding(s) total` (first try).
2. `main.rs` canonical wiring already in place on all 3 binaries
   (no changes needed).
3. `cargo update` clean; lockfile reflects latest Proc SDK
   (a436a20f from s97) + `herolib_core` (9b5912bf from s96).
4. `Cargo.toml` deps audited; 7 zero-match deps stripped.
5. `lab service hero_db_server --install --start` → smoke 4/4 passed
   (GET /health, GET /openrpc.json, GET /.well-known/heroservice.json,
   POST /rpc system.ping); `lab service hero_db_admin --install --start`
   → smoke 2/2 passed.

## Test impact

`cargo test --workspace --release --no-fail-fast`: **75 passed, 0 failed,
10 ignored.** No regressions.

Signed-off-by: mik-tf <logismos@protonmail.ch>