fix(ui): send enabled SSH keys in deploy_vm request with fetch/cache fallback #61

Open

nabil_salah wants to merge 6 commits from development_fix_deploy_ssh_keys_target_node into development

pull from: development_fix_deploy_ssh_keys_target_node

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:development_show_node_versions

lhumina_code:development_fix_congfig_script

lhumina_code:development_tfgrid

lhumina_code:development_hero_router

lhumina_code:main

Conversation 0 Commits 6 Files changed 7 +154 -11

nabil_salah commented 2026-04-05 15:19:29 +00:00

Member

Copy link

• #56

- https://forge.ourworld.tf/lhumina_code/hero_compute/issues/56

nabil_salah added 1 commit 2026-04-05 15:19:29 +00:00

fix(ui): send enabled SSH keys in deploy_vm request with fetch/cache fallback ... 464d3a28ce

Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>

nabil_salah added 1 commit 2026-04-05 15:26:36 +00:00

fix(ssh): merge deploy-provided keys with target-node secret store and deduplicate before VM injection ... de4c7c894a

Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>

nabil_salah added 1 commit 2026-04-05 15:43:14 +00:00

refactor(ui): simplify deploy key flow; fetch SSH keys only for explorer deploy with cache-fallback warning ... 551aaaa61c

Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>

nabil_salah added 1 commit 2026-04-06 12:46:08 +00:00

fix: fetch: worked ssh keys and add to deploy ssh keys ... 7bbdf954b2

Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>

nabil_salah added 1 commit 2026-04-06 13:42:39 +00:00

refactor: update get ssh failure message ... 3a2fba5a2b

Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>

nabil_salah added 1 commit 2026-04-06 14:33:00 +00:00

fix: get_ssh_keys expects it's secret to be send while it was master secret what was sent ... 42f1a2caf1

Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>

nabil_salah added 1 commit 2026-04-06 15:22:51 +00:00

fix: making differant endpoint for ssh keys to not break the old one ... 38019e8048

Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>

nabil_salah force-pushed development_fix_deploy_ssh_keys_target_node from 38019e8048 to f2b07f7779 2026-04-06 16:21:02 +00:00 Compare

nabil_salah force-pushed development_fix_deploy_ssh_keys_target_node from f2b07f7779 to bcababe093 2026-04-06 16:26:12 +00:00 Compare

All checks were successful

Hide all checks

Test / test (pull_request) Successful in 1m26s

Details

Test / test (push) Successful in 2m30s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin development_fix_deploy_ssh_keys_target_node:development_fix_deploy_ssh_keys_target_node

git switch development_fix_deploy_ssh_keys_target_node

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff development_fix_deploy_ssh_keys_target_node

git switch development_fix_deploy_ssh_keys_target_node

git rebase development

git switch development

git merge --ff-only development_fix_deploy_ssh_keys_target_node

git switch development_fix_deploy_ssh_keys_target_node

git rebase development

git switch development

git merge --no-ff development_fix_deploy_ssh_keys_target_node

git switch development

git merge --squash development_fix_deploy_ssh_keys_target_node

git switch development

git merge --ff-only development_fix_deploy_ssh_keys_target_node

git switch development

git merge development_fix_deploy_ssh_keys_target_node

git push origin development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

prio_critical

  

prio_low

  

type_bug

  

type_contact

  

type_issue

  

type_lead

  

type_question

  

type_story

  

type_task

No labels

prio_critical

prio_low

type_bug

type_contact

type_issue

type_lead

type_question

type_story

type_task

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_compute!61

No description provided.