WIP: Fix broken images in MD and PDF books #85

Draft

fatmaebrahim wants to merge 7 commits from development_fix_broken_images_in_pdf_and_md into development

pull from: development_fix_broken_images_in_pdf_and_md

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:development_dioxus_bootstrap

lhumina_code:development_kristof

lhumina_code:main

Conversation 0 Commits 7 Files changed 15 +153 -101

fatmaebrahim commented 2026-03-18 10:17:57 +00:00

Member

Copy link

Description:

This PR include a fix for broken images in md preview and pdf books
It includes the following changes:

• added rewrite_image_urls function to handle md
• added handle_img_name function to handle pdf

Changes:

• md preview fixed:

• pdf books fixed:

### Description: This PR include a fix for broken images in md preview and pdf books It includes the following changes: - added rewrite_image_urls function to handle md - added handle_img_name function to handle pdf ### Changes: - md preview fixed:  - pdf books fixed: 

image.png

1.5 MiB

image.png

892 KiB

fatmaebrahim added 1 commit 2026-03-18 10:17:57 +00:00

fix: added rewrite_image_urls function to handle md and handle_img_name function to handle pdf 6f1ffeac48

fatmaebrahim added 1 commit 2026-03-18 11:15:58 +00:00

added comment 98b38686c2

mahmoud added 1 commit 2026-03-18 12:01:18 +00:00

ci: Add token to checkout action ... 3f9b7ded2e

- Configure checkout with FORGEJO_TOKEN

mahmoud added 1 commit 2026-03-18 12:05:33 +00:00

ci: Use custom git clone for repository checkout ... fc64d4e654

- Replace `actions/checkout@v4`
- Implement custom `git clone` command
- Add current directory to Git safe directories
- Determine branch from `GITHUB_HEAD_REF` or `GITHUB_REF_NAME`
- Clone repository from `forge.ourworld.tf`

fatmaebrahim added 1 commit 2026-03-18 12:12:31 +00:00

fix: cargo fmt a17f6d5ab1

fatmaebrahim added 1 commit 2026-03-18 12:28:55 +00:00

version downgrade 164b866b1c

fatmaebrahim force-pushed development_fix_broken_images_in_pdf_and_md from 164b866b1c to a17f6d5ab1 2026-03-18 12:35:08 +00:00 Compare

fatmaebrahim added 1 commit 2026-03-18 12:37:27 +00:00

added toolchain to fix rustc version mismatch f526724669

fatmaebrahim added 1 commit 2026-03-18 12:56:46 +00:00

removed --skip-discover option c870736df1

fatmaebrahim force-pushed development_fix_broken_images_in_pdf_and_md from c870736df1 to f526724669 2026-03-18 13:04:28 +00:00 Compare

fatmaebrahim added 1 commit 2026-03-18 13:06:06 +00:00

removed --skip-discover option 30175066bb

All checks were successful

Hide all checks

Test / test (pull_request) Successful in 6m39s

Details

Test / integration (pull_request) Successful in 4m6s

Details

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin development_fix_broken_images_in_pdf_and_md:development_fix_broken_images_in_pdf_and_md

git switch development_fix_broken_images_in_pdf_and_md

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff development_fix_broken_images_in_pdf_and_md

git switch development_fix_broken_images_in_pdf_and_md

git rebase development

git switch development

git merge --ff-only development_fix_broken_images_in_pdf_and_md

git switch development_fix_broken_images_in_pdf_and_md

git rebase development

git switch development

git merge --no-ff development_fix_broken_images_in_pdf_and_md

git switch development

git merge --squash development_fix_broken_images_in_pdf_and_md

git switch development

git merge --ff-only development_fix_broken_images_in_pdf_and_md

git switch development

git merge development_fix_broken_images_in_pdf_and_md

git push origin development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_books!85

No description provided.