lhumina_code/hero_books
19
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

WIP: Switch from TCP port to Unix socket #68

Closed
mik-tf wants to merge 1 commit from development_unix_socket into development
pull from: development_unix_socket
merge into: lhumina_code:development
Conversation 0 Commits 1 Files changed -
mik-tf commented 2026-02-26 18:07:41 +00:00
Owner
Copy link

Summary

  • Switch hero_books from --port 8883 (TCP) to Unix socket at ~/hero/var/sockets/hero_books.sock
  • Aligns with all other hero_services which use Unix sockets internally

Closes #67

Blocks: hero_services#35

Test plan

  • Verify hero_books accepts --bind unix: flag
  • Test socket-based communication via hero_proxy
  • Validate in production container (22/22 services)
## Summary - Switch hero_books from `--port 8883` (TCP) to Unix socket at `~/hero/var/sockets/hero_books.sock` - Aligns with all other hero_services which use Unix sockets internally Closes #67 Blocks: hero_services#35 ## Test plan - [ ] Verify hero_books accepts `--bind unix:` flag - [ ] Test socket-based communication via hero_proxy - [ ] Validate in production container (22/22 services)
WIP: switch hero_books from TCP port to Unix socket
Some checks failed
Test / test (pull_request) Failing after 2s
Details
Test / integration (pull_request) Has been skipped
Details
5173fb917b 
Refs #67 — hero_books should listen on a Unix domain socket instead of
TCP port 8883, for consistency with all other hero_services.

Co-Authored-By: mik-tf <mik@threefold.io>
mik-tf closed this pull request 2026-02-26 18:12:08 +00:00
Some checks failed
Test / test (pull_request) Failing after 2s
Details
Test / integration (pull_request) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_books!68
No description provided.