lhumina_code/hero_books
20
0
Fork 0
Code Issues 1 Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: repair CI — build workspace binaries, fix fmt/clippy, non-fatal embedder check #64

Closed
mik-tf wants to merge 4 commits from development_ci_work into development
pull from: development_ci_work
merge into: lhumina_code:development
Conversation 1 Commits 4 Files changed 22 +1025 -454
mik-tf commented 2026-02-26 00:28:04 +00:00
Owner
Copy link

Summary

  • Remove missing ci-patch-deps.sh references from test.yaml
  • Add --workspace to build() in build_lib.sh so workspace member binaries are built
  • Fix all cargo fmt issues across workspace
  • Comment out build.rs OSchema code generation (was regenerating on every build, overwriting fixes)
  • Remove duplicate #![cfg(test)] from generated test files (parent mod.rs already gates)
  • Make hero_embedder health check non-fatal — server starts in degraded mode when embedder is unavailable

Closes #58
Closes #65

## Summary - Remove missing `ci-patch-deps.sh` references from test.yaml - Add `--workspace` to `build()` in build_lib.sh so workspace member binaries are built - Fix all `cargo fmt` issues across workspace - Comment out build.rs OSchema code generation (was regenerating on every build, overwriting fixes) - Remove duplicate `#![cfg(test)]` from generated test files (parent mod.rs already gates) - Make hero_embedder health check non-fatal — server starts in degraded mode when embedder is unavailable Closes #58 Closes #65
fix: repair CI — build workspace binaries and remove missing ci-patch-deps.sh
Some checks failed
Test / test (pull_request) Failing after 20s
Details
Test / integration (pull_request) Has been skipped
Details
b8a7127647 
build_lib.sh build() was missing --workspace flag, so only root package
binaries (hero_books, hero_books_client) were produced — hero_books_server
and hero_books_ui were skipped. test.yaml referenced scripts/ci-patch-deps.sh
which was removed along with .forgejo/deps.txt, causing immediate failure.

Co-Authored-By: mik-tf <perreault@incubaid.com>
style: fix cargo fmt issues across workspace
Some checks failed
Test / test (pull_request) Successful in 7m33s
Details
Test / integration (pull_request) Failing after 2m48s
Details
b70df11b00 
Pre-existing formatting issues in SDK, server, UI, and generated OSIS
code that caused ci_check to fail at the fmt step.

Signed-off-by: mik-tf <mik@threefold.io>
fix: disable build.rs codegen and remove duplicate #![cfg(test)]
Some checks failed
Test / test (pull_request) Successful in 6m25s
Details
Test / integration (pull_request) Failing after 10m28s
Details
8b8b505fbe 
The OSchema generator in build.rs was running on every build,
overwriting manually-fixed files. Comment out generation (as intended
per the build.rs instructions) and remove redundant #![cfg(test)]
from test files (parent mod.rs already gates with #[cfg(test)]).

Fixes clippy::duplicated_attributes error that blocked make lint.

Signed-off-by: mik-tf <mik@threefold.io>
fix: make hero_embedder health check non-fatal at startup
All checks were successful
Test / test (pull_request) Successful in 7m39s
Details
Test / integration (pull_request) Successful in 8m22s
Details
bce7b98215 
The mandatory health check blocked server startup when hero_embedder
was unavailable (e.g. CI). Now logs a warning and continues in
degraded mode — vector search returns errors at call time instead
of preventing the entire service from starting.

Closes #65

Signed-off-by: mik-tf <mik@threefold.io>
mik-tf changed title from WIP: fix: repair CI — build workspace binaries and remove missing ci-patch-deps.sh to fix: repair CI — build workspace binaries and remove missing ci-patch-deps.sh 2026-02-26 02:35:23 +00:00
mik-tf changed title from fix: repair CI — build workspace binaries and remove missing ci-patch-deps.sh to fix: repair CI — build workspace binaries, fix fmt/clippy, non-fatal embedder check 2026-02-26 03:36:00 +00:00
mik-tf closed this pull request 2026-03-01 15:06:18 +00:00
mik-tf commented 2026-03-01 15:06:26 +00:00
Author
Owner
Copy link

Superseded by PR #73 which combines this work with additional fixes (rust-toolchain.toml removal, dead module cleanup, WIP directory renames).

Superseded by PR #73 which combines this work with additional fixes (rust-toolchain.toml removal, dead module cleanup, WIP directory renames).
All checks were successful
Test / test (pull_request) Successful in 7m39s
Details
Test / integration (pull_request) Successful in 8m22s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_books!64
No description provided.