WIP: Fix pid1 integration tests, clippy warnings, and CI triggers #22

Draft

mik-tf wants to merge 4 commits from development_fix_ci_tests into development

pull from: development_fix_ci_tests

merge into: geomind_code:development

geomind_code:development

geomind_code:development_tty

geomind_code:development_fix_herolib_core_dep

geomind_code:development_fix_ci_build

geomind_code:development_rename

geomind_code:main

Conversation 0 Commits 4 Files changed 7 +95 -102

mik-tf commented 2026-02-26 17:58:07 +00:00

Member

Copy link

Summary

• Fix env var mismatch: tests passed ZINIT_SERVER_BIN but pid1 reads ZINIT_OPENRPC_BIN, causing pid1 to fall back to hardcoded /sbin/ paths that don't exist in CI
• Fix clippy zombie_processes lint: add .wait() after .kill() in test cleanup
• Update integration README to reference correct env var
• Narrow build.yaml and test.yaml push triggers from ["*"] to [development, main]

Depends on #20 being merged first (build-linux fix).

Ref #21

## Summary - Fix env var mismatch: tests passed `ZINIT_SERVER_BIN` but pid1 reads `ZINIT_OPENRPC_BIN`, causing pid1 to fall back to hardcoded `/sbin/` paths that don't exist in CI - Fix clippy `zombie_processes` lint: add `.wait()` after `.kill()` in test cleanup - Update integration README to reference correct env var - Narrow `build.yaml` and `test.yaml` push triggers from `["*"]` to `[development, main]` Depends on #20 being merged first (build-linux fix). Ref #21

mik-tf self-assigned this 2026-02-26 17:58:07 +00:00

mik-tf added 1 commit 2026-02-26 17:58:07 +00:00

fix: fix pid1 integration tests and narrow CI triggers ... 662b4302a5

- Fix env var mismatch: tests passed ZINIT_SERVER_BIN but pid1 reads
  ZINIT_OPENRPC_BIN — pid1 was falling back to hardcoded /sbin/ paths
- Fix clippy zombie_processes: add .wait() after .kill() in test cleanup
- Update README to reference correct env var name
- Narrow build.yaml and test.yaml push triggers from ["*"] to
  [development, main] to match build-linux.yaml

Ref #21

mik-tf added 1 commit 2026-02-26 18:01:05 +00:00

fix: collapse nested if blocks to satisfy clippy collapsible_if lint ... ecd625e345

Ref #21

mik-tf added 1 commit 2026-02-26 18:05:39 +00:00

fix: resolve remaining clippy lints across zinit_openrpc and tests ... 54385f15c8

- graph.rs: collapse nested if/if-let chains (7 locations)
- ipc.rs: replace single-pattern match with if-let
- process.rs: collapse nested if/if-let chains (2 locations)
- pid1_behavior.rs: remove unnecessary mut

Ref #21

mik-tf added 1 commit 2026-02-26 18:08:19 +00:00

fix: use irrefutable let for reboot() which returns Result<Infallible> ... 885cb4a04d

reboot() never returns on success (system reboots), so Err is the
only reachable case. Use `let Err(e) =` instead of `if let Err(e) =`.

Ref #21

All checks were successful

Hide all checks

Build and Test / build (pull_request) Successful in 2m9s

Details

Tests / test (pull_request) Successful in 3m14s

Details

This pull request has changes conflicting with the target branch.

• tests/integration/README.md

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin development_fix_ci_tests:development_fix_ci_tests

git switch development_fix_ci_tests

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff development_fix_ci_tests

git switch development_fix_ci_tests

git rebase development

git switch development

git merge --ff-only development_fix_ci_tests

git switch development_fix_ci_tests

git rebase development

git switch development

git merge --no-ff development_fix_ci_tests

git switch development

git merge --squash development_fix_ci_tests

git switch development

git merge --ff-only development_fix_ci_tests

git switch development

git merge development_fix_ci_tests

git push origin development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

mik-tf

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

geomind_code/zinit!22

No description provided.