Error handling refactor and sanitizing #4

Closed

delandtj wants to merge 0 commits from sanitizing into main

delandtj commented

2026-01-06 21:27:23 +00:00

Owner

Summary

Cleanup and modernize codebase: fix build issues, remove bollard dependency, rename docker→container
Refactor error handling with unified error type for better debugging and maintainability

Changes

Build & Dependencies Cleanup

Fix Rust 2024 never type fallback warning
Remove bollard, futures-util, tokio-async-drop dependencies
Replace Docker API with podman CLI for container-to-flist conversion
Rename docker module to container (DockerImageToFlist → ContainerImageToFlist)
Fix 33 clippy warnings, remove dead code
Add credential support for private registries via podman --creds

Unified Error Handling

Add src/error.rs with centralized Error type replacing scattered error enums
Add error classification methods: is_transient(), is_fatal(), to_errno()
Remove catch-all Anyhow variants that defeated type safety
Remove process::exit(1) from library code
Improve error messages:
- MultipleStoreErrors now shows actual error details, not just count
- S3 XML errors parsed to human-readable format (e.g., "AccessDenied: Forbidden: No such key")

Test plan

cargo clippy passes with no warnings
cargo test - all 22 tests pass
Manual test: mount flist and verify improved error messages

Summary - Cleanup and modernize codebase: fix build issues, remove bollard dependency, rename docker→container - Refactor error handling with unified error type for better debugging and maintainability Changes Build & Dependencies Cleanup - Fix Rust 2024 never type fallback warning - Remove bollard, futures-util, tokio-async-drop dependencies - Replace Docker API with podman CLI for container-to-flist conversion - Rename docker module to container (DockerImageToFlist → ContainerImageToFlist) - Fix 33 clippy warnings, remove dead code - Add credential support for private registries via podman --creds Unified Error Handling - Add src/error.rs with centralized Error type replacing scattered error enums - Add error classification methods: is_transient(), is_fatal(), to_errno() - Remove catch-all Anyhow variants that defeated type safety - Remove process::exit(1) from library code - Improve error messages: - MultipleStoreErrors now shows actual error details, not just count - S3 XML errors parsed to human-readable format (e.g., "AccessDenied: Forbidden: No such key") Test plan - cargo clippy passes with no warnings - cargo test - all 22 tests pass - Manual test: mount flist and verify improved error messages

delandtj added 2 commits

2026-01-06 21:27:24 +00:00

Cleanup: fix build, remove bollard, rename docker to container 6011e16952

- Fix Rust 2024 never type fallback in zdb.rs
- Remove bollard, futures-util, tokio-async-drop dependencies
- Replace Docker API with podman CLI for container-to-flist conversion
- Rename docker module to container (DockerImageToFlist -> ContainerImageToFlist)
- Fix 33 clippy warnings across codebase
- Remove dead code (PARALLEL_DOWNLOAD, ParallelCopyVisitor, unused test helpers)
- Add credential support for private registries via podman --creds

Refactor error handling with unified error type 9a0f1f87b3

Introduces a centralized error handling architecture that replaces
scattered error types with a single, well-structured Error enum.

Key changes:
- Add src/error.rs with unified Error type and classification methods
  (is_transient, is_fatal, to_errno for FUSE compatibility)
- Remove fungi::meta::Error and store::Error enums
- Eliminate catch-all Anyhow variants that defeated type safety
- Remove process::exit(1) from library code (pack.rs)
- Replace anyhow::Context usage with explicit error mapping

Error reporting improvements:
- MultipleStoreErrors now shows actual error details, not just count
- S3 XML error responses are parsed to show Code/Message/Resource
  instead of raw XML (e.g., "AccessDenied: Forbidden: No such key")

All error variants are explicit with proper source chains for debugging.
Includes ADR document explaining the design decisions.

delandtj commented

2026-01-06 21:31:38 +00:00

Author

Owner

@rawdaGastan
can you fix the src/store/zdb.rs conflict ? (anyway, I guess with the advent of herodb, the zdb.rs is dead in the water)

@rawdaGastan can you fix the src/store/zdb.rs conflict ? (anyway, I guess with the advent of herodb, the zdb.rs is dead in the water)

delandtj added 1 commit

2026-01-06 22:09:43 +00:00

Add ADR-002: Workspace restructuring plan fafd7f4e42

Proposes splitting monolithic myfs crate into workspace with:
- myfs-core: shared library (error, fungi, store, cache)
- myfs-server: HTTP server + admin tools (serve, token, track, website-publish)
- myfstool: advanced operations (container, clone, merge, sync)
- myfs: core flist operations (mount, config, pack, unpack, upload, download, exists, flist inspect)

Includes detailed implementation phases, file movement tables,
dependency graph, and command mapping.

delandtj added 1 commit

2026-01-06 22:15:23 +00:00

Add ADR-003: FUSE error handling improvements b1b834ff86

Proposes fixing the catch-all error handler that converts all FUSE
errors to ENOENT. Instead, use the unified error type's to_errno()
method to map errors appropriately:

- BlockNotFound → ENOENT (file doesn't exist)
- StoreUnavailable → EAGAIN (retry later)
- Encryption/IO errors → EIO (I/O error)

This allows applications to distinguish transient errors (and retry)
from permanent ones.