Merge branch 'copilot/fix-104' into development

* copilot/fix-104:
  Complete testing of all biztools examples - all 11 scripts are non-functional
  Initial plan
This commit is contained in:
2025-08-11 21:25:57 +02:00

View File

@@ -0,0 +1,92 @@
# Biztools Examples Test Results
This document reports the status of each biztools example script.
## Test Results
| Script Name | Status | Error/Notes |
|-------------|--------|-------------|
| bizmodel.vsh | ❌ NOT WORKING | Missing playbook directory |
| bizmodel1.vsh | ❌ NOT WORKING | API compatibility issue - heroscript field not recognized |
| bizmodel2.vsh | ❌ NOT WORKING | API compatibility issue - heroscript field not recognized |
| bizmodel_complete.vsh | ❌ NOT WORKING | API compatibility issue - heroscript_path field not recognized |
| bizmodel_export.vsh | ❌ NOT WORKING | API compatibility issue - heroscript_path field not recognized |
| bizmodel_full.vsh | ❌ NOT WORKING | API compatibility issue - heroscript_path field not recognized |
| costs.vsh | ❌ NOT WORKING | API compatibility issue - heroscript field not recognized |
| funding.vsh | ❌ NOT WORKING | API compatibility issue - heroscript field not recognized |
| hr.vsh | ❌ NOT WORKING | API compatibility issue - heroscript field not recognized |
| _archive/investor_tool.vsh | ❌ NOT WORKING | Module definition error - module defined as 'main' instead of expected name |
| _archive/tf9_biz.vsh | ❌ NOT WORKING | Missing import - mdbook module not found |
**Test executed on:** August 9, 2024 (UTC)
**V Version:** V 0.4.11 a11de72
## Summary
**Total Scripts Tested:** 11
**Working Scripts:** 0
**Non-Working Scripts:** 11
**Success Rate:** 0%
---
## Working Examples
**None** - All tested scripts are currently non-functional.
## Non-Working Examples
### API Compatibility Issues (8 scripts)
The following scripts fail due to API breaking changes in the herolib bizmodel module:
- **bizmodel1.vsh, bizmodel2.vsh, costs.vsh, funding.vsh, hr.vsh**:
- Error: `unknown field 'heroscript' in struct literal of type 'freeflowuniverse.herolib.core.playbook.PlayBook'`
- Error: `reference field 'freeflowuniverse.herolib.core.playbook.PlayBook.session' must be initialized`
- Error: function parameter `plbook` is `mut`, requires `mut freeflowuniverse.herolib.core.playbook.PlayBook{....}`
- **bizmodel_complete.vsh, bizmodel_export.vsh, bizmodel_full.vsh**:
- Error: `unknown field 'heroscript_path' in struct literal of type 'freeflowuniverse.herolib.core.playbook.PlayBook'`
- Same session initialization and mut parameter issues
### Missing Files/Dependencies (1 script)
- **bizmodel.vsh**:
- Error: `can't find path:/home/runner/work/herolib/herolib/examples/biztools/playbook`
- Missing required playbook directory
### Module Definition Issues (1 script)
- **_archive/investor_tool.vsh**:
- Error: `bad module definition: ./investor_tool.vsh imports module "freeflowuniverse.herolib.biz.investortool" but /home/runner/.vmodules/freeflowuniverse/herolib/biz/investortool/investortool2.v is defined as module 'main'`
### Missing Module Issues (1 script)
- **_archive/tf9_biz.vsh**:
- Error: `cannot import module "freeflowuniverse.herolib.web.mdbook" (not found)`
## Root Cause Analysis
The primary issues appear to be:
1. **Breaking API Changes**: The herolib bizmodel API has changed significantly, making the old `heroscript` and `heroscript_path` parameters invalid, and requiring proper session initialization.
2. **Module Inconsistencies**: Some modules have naming/definition inconsistencies.
3. **Missing Dependencies**: Some required modules (like mdbook) are not available.
4. **Missing Required Files**: Some examples expect specific directory structures or files that are not present.
## Recommendations
1. **Update examples** to match the current herolib API
2. **Fix module definitions** where inconsistent
3. **Add missing dependencies** or remove references to unavailable modules
4. **Create missing required files** or update examples to not depend on them
5. **Add proper error handling** for missing dependencies
## Notes
- All scripts were tested in a clean environment with V 0.4.11 installed
- Tests were run from the /examples/biztools/ directory
- HeroLib was properly installed using ./install_herolib.vsh
- Redis service was started as required