tfgrid/docs_tfgrid4
7
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Home Page Icon Color Changes with Dark Mode + Refresh #11

New Issue
Closed
opened 2024-09-04 20:20:21 +00:00 by mik-tf · 1 comment
mik-tf commented 2024-09-04 20:20:21 +00:00
Owner
Copy Link

Situation

  • the docs Home Page Icons' Color Change with Dark Mode + Refresh

To Reproduce

  • go to docs.threefold.info
  • put dark mode
  • refresh the page
  • result: the icon are grey non white

Todo

  • Ensure the color stays the same (white)

Screenshots

  • Dark Mode before refresh

image

  • After refresh

image

References

@ehab could you have a look? Thanks!

Ideas

I think the fix would be around this: h

docs_website/src/components/HomepageFeatures/index.tsx Line 53 in 067c7114a6
} else if ( id === 'svgcolor' && colorMode === 'dark') {

# Situation - the docs Home Page Icons' Color Change with Dark Mode + Refresh # To Reproduce - go to docs.threefold.info - put dark mode - refresh the page - result: the icon are grey non white # Todo - Ensure the color stays the same (white) # Screenshots - Dark Mode before refresh ![image](/attachments/44a658d1-29b9-4577-a49c-d0cd60f72175) - After refresh ![image](/attachments/118ebf81-21a4-40ec-973c-2a4372fba1ce) # References - Website: - https://docs.threefold.info/ @ehab could you have a look? Thanks! # Ideas I think the fix would be around this: hhttps://git.ourworld.tf/tfgrid/docs_tfgrid4/src/commit/067c7114a62152e2a4a180902e128890e97f3819/docs_website/src/components/HomepageFeatures/index.tsx#L53
image.png
42 KiB
image.png
37 KiB
ehab was assigned by mik-tf 2024-09-04 20:24:08 +00:00
ehab commented 2024-09-09 10:01:47 +00:00
Member
Copy Link

@mik-tf
I changed the way images switch between dark and light modes by adding at custome.css
created a new PR request and need to test it at the production because it's working fine locally

@mik-tf I changed the way images switch between dark and light modes by adding at custome.css created a new PR request and need to test it at the production because it's working fine locally
❤️ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Issue

   
Question

   
Roadmap

   
Story

   
Task

   
Urgent
No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Issue
Question
Roadmap
Story
Task
Urgent
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
ehab
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tfgrid/docs_tfgrid4#11
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?