Migrate remaining services to HeroRpcServer lifecycle CLI pattern #52
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Part of the hero_proc migration (#50). hero_services now uses hero_proc_sdk instead of zinit_sdk, and the Docker deployment works with hero_proc_server as the process manager.
Problem
5 service binaries still use the old CLI pattern (no subcommands, direct [OPTIONS]). They need migration to the new HeroRpcServer/HeroUiServer pattern from hero_rpc, which provides lifecycle subcommands: serve, start, stop, status, logs, etc.
Services needing migration
Investigation needed
Kristof development_kristof merge may have lost migration work for these services (similar to video/OTOML loss in hero_osis). Check git history in each repo for any HeroRpcServer migration that was reverted.
Why it matters
References
Signed-off-by: mik-tf
Done — all 5 services migrated to HeroRpcServer CLI pattern
All services now accept
servesubcommand + lifecycle commands (run, start, stop, status, logs).Service TOMLs updated: hero_services@de92654
Build verified:
SKIP_WASM=1 make distpasses, all binaries acceptservesubcommand.