Fix pre-existing preflight errors in hero_rpc #37

New issue

Open

opened 2026-03-18 17:14:27 +00:00 by mik-tf · 0 comments

mik-tf commented

2026-03-18 17:14:27 +00:00

Owner

Problem

make preflight in hero_services reports errors from hero_rpc that pre-date any recent work:

1. Path dependency: `crates/infra`

Commented out in workspace Cargo.toml (# "crates/infra") but preflight script still detects it.

2. Example path deps

crates/server/examples/recipe_server/Cargo.toml references hero_lib paths that don't exist in the standard checkout:

../../../../../../hero_lib/crates/core
../../../../../../hero_lib/crates/sid

3. Cargo.lock revspec issues

Some pinned git commits appear to have been force-pushed:

hero_rpc.git revspec eee9a4c4343a not found on remote
hero_osis.git revspec 82cce94a40d4 not found on remote (affects hero_archipelagos, hero_os)
my_hypervisor.git revspec af7e1e59dd5d not found (affects hero_cloud)

Impact

These don't break make dist (the affected crates aren't compiled), but they cause make preflight to fail, preventing it from being used as a build gate.

Fix

Remove or fix the crates/infra reference in hero_rpc workspace Cargo.toml
Either remove the recipe_server example or make its deps self-contained
Run cargo update on affected repos to resolve to reachable commits

## Problem `make preflight` in hero_services reports errors from hero_rpc that pre-date any recent work: ### 1. Path dependency: `crates/infra` Commented out in workspace Cargo.toml (`# "crates/infra"`) but preflight script still detects it. ### 2. Example path deps `crates/server/examples/recipe_server/Cargo.toml` references `hero_lib` paths that don't exist in the standard checkout: - `../../../../../../hero_lib/crates/core` - `../../../../../../hero_lib/crates/sid` ### 3. Cargo.lock revspec issues Some pinned git commits appear to have been force-pushed: - `hero_rpc.git` revspec `eee9a4c4343a` not found on remote - `hero_osis.git` revspec `82cce94a40d4` not found on remote (affects hero_archipelagos, hero_os) - `my_hypervisor.git` revspec `af7e1e59dd5d` not found (affects hero_cloud) ## Impact These don't break `make dist` (the affected crates aren't compiled), but they cause `make preflight` to fail, preventing it from being used as a build gate. ## Fix 1. Remove or fix the `crates/infra` reference in hero_rpc workspace Cargo.toml 2. Either remove the recipe_server example or make its deps self-contained 3. Run `cargo update` on affected repos to resolve to reachable commits