build_lib.sh issues #67
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_skills#67
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
proc_kill() uses pkill -f which matches the full command line. When make run calls hero_service_stop, the parent bash shell's command line contains hero_proc_server/hero_proc_ui as arguments, so proc_kill kills make itself.
Fix: use pkill -x / pgrep -x for exact process name matching.
Also: hero_service_stop() hardcodes hero_proc_* names instead of deriving them from arguments — should be parameterized.
Another thing I'm running into is the fact that these ncat calls bind to localhost only. This isn't working well for remote development on an external machine.
now all replaced by service_... nu scripts