OServer should register a `system.ping` builtin (skill smoke test expects it) #80

New issue

Closed

opened 2026-05-20 05:56:42 +00:00 by timur · 1 comment

timur commented

2026-05-20 05:56:42 +00:00

Owner

Context

From the hero_logic#41 §1 audit.

The hero_service_check_fix.md skill §7 prescribes POST /rpc {"method":"system.ping"} as part of the standard smoke test. hero_rpc2 includes system.ping (see example/recipe_sdk_rpc2/tests/debug_curl.rs), but hero_rpc_server::OServer — what current OSIS-backed services like hero_logic run on — does NOT register any system.* builtins.

Result: hero_logic's rpc socket returns:

{"error":{"code":-32000,"message":"Unknown method: system.ping. Available: ..."}}

Decision needed

Two paths:

A. Add system.ping (and minimal system.* builtins like system.version, system.openrpc) to OServer so every OSIS service satisfies the skill out of the box.
B. Update the hero_service_check_fix.md skill §7 to acknowledge that system.* methods require hero_rpc2; OSIS-only services exercise /health + /openrpc.json + a service-specific method instead.

My lean: A. The skill describes what every Hero service should answer; users shouldn't have to think about which RPC stack the service runs on. OServer already has the dispatch infrastructure — adding system.ping is a few lines.

Comment with your call.

Acceptance

Decision documented in this thread.
Implementation per the chosen path.
hero_logic (and any other OSIS-only service) clears the §7 smoke test without modification.

## Context From the [hero_logic#41 §1 audit](https://forge.ourworld.tf/lhumina_code/hero_logic/issues/41#issuecomment-34455). The `hero_service_check_fix.md` skill §7 prescribes `POST /rpc {"method":"system.ping"}` as part of the standard smoke test. `hero_rpc2` includes `system.ping` (see `example/recipe_sdk_rpc2/tests/debug_curl.rs`), but `hero_rpc_server::OServer` — what current OSIS-backed services like `hero_logic` run on — does NOT register any `system.*` builtins. Result: `hero_logic`'s rpc socket returns: ``` {"error":{"code":-32000,"message":"Unknown method: system.ping. Available: ..."}} ``` ## Decision needed Two paths: - **A.** Add `system.ping` (and minimal `system.*` builtins like `system.version`, `system.openrpc`) to `OServer` so every OSIS service satisfies the skill out of the box. - **B.** Update the `hero_service_check_fix.md` skill §7 to acknowledge that `system.*` methods require hero_rpc2; OSIS-only services exercise `/health` + `/openrpc.json` + a service-specific method instead. My lean: **A**. The skill describes what every Hero service should answer; users shouldn't have to think about which RPC stack the service runs on. `OServer` already has the dispatch infrastructure — adding `system.ping` is a few lines. Comment with your call. ## Acceptance - Decision documented in this thread. - Implementation per the chosen path. - `hero_logic` (and any other OSIS-only service) clears the §7 smoke test without modification.

timur referenced this issue from lhumina_code/hero_logic

2026-05-20 05:57:01 +00:00

Audit alignment with hero_skills + assess migration to upgraded hero_rpc #41

timur referenced this issue from lhumina_code/hero_skills

2026-05-20 05:57:18 +00:00

[META] Standardize Hero service architecture — template, hero_rpc alignment, framework hoist, skills #262

timur referenced this issue from lhumina_code/hero_skills

2026-05-20 06:53:09 +00:00

[META] Standardize Hero service architecture — template, hero_rpc alignment, framework hoist, skills #262

timur referenced this issue from lhumina_code/hero_skills

2026-05-20 06:59:12 +00:00

[META] Standardize Hero service architecture — template, hero_rpc alignment, framework hoist, skills #262

timur referenced this issue

2026-05-20 09:40:41 +00:00

Migrate OSIS services off OServer onto hero_rpc2 trait/dispatch — close the META hybrid loop #90

timur commented

2026-05-20 09:40:42 +00:00

Author

Owner

Closing — supplanted by #90.

The system.ping gap was a symptom of OSIS services still running on OServer instead of hero_rpc2 (which registers system.* natively). Patching OServer with a builtin would be a stopgap; the parent META always intended for OSIS services to migrate to hero_rpc2. #90 tracks that proper migration. Once services move, this issue resolves automatically.

Closing — supplanted by [#90](https://forge.ourworld.tf/lhumina_code/hero_rpc/issues/90). The `system.ping` gap was a symptom of OSIS services still running on OServer instead of hero_rpc2 (which registers `system.*` natively). Patching OServer with a builtin would be a stopgap; the parent META always intended for OSIS services to migrate to hero_rpc2. #90 tracks that proper migration. Once services move, this issue resolves automatically.

timur closed this issue

2026-05-20 09:40:42 +00:00

timur referenced this issue from lhumina_code/hero_skills

2026-05-20 09:41:12 +00:00

[META] Standardize Hero service architecture — template, hero_rpc alignment, framework hoist, skills #262

timur referenced this issue

2026-05-20 09:57:49 +00:00

Migrate OSIS services off OServer onto hero_rpc2 trait/dispatch — close the META hybrid loop #90

timur referenced this issue from a commit

2026-05-20 12:02:05 +00:00

feat(hero_rpc2): route POST /rpc + serve well-known endpoints (#90)

timur referenced this issue