RPC client should prefix method names with domain for 3-part dispatch #3

Closed
opened 2026-03-01 14:17:43 +00:00 by mik-tf · 0 comments
Owner

Problem

The OsisClient's rpc_call method needs to prefix method names with the domain name to produce the 3-part domain.Type.method format expected by the Unix socket dispatch.

Without this, service calls like authservice.get_challenge are sent as-is (2-part), but the raw Unix socket dispatcher expects identity.authservice.get_challenge (3-part).

Fix

The rpc_call method in packages/client/src/lib.rs constructs full_method = format!("{}.{}", self.domain, method) before sending the JSON-RPC request.

This was implemented in commit c75a0c6 but pushed directly to development without a PR. This issue documents it retroactively so it can go through proper review.

## Problem The OsisClient's `rpc_call` method needs to prefix method names with the domain name to produce the 3-part `domain.Type.method` format expected by the Unix socket dispatch. Without this, service calls like `authservice.get_challenge` are sent as-is (2-part), but the raw Unix socket dispatcher expects `identity.authservice.get_challenge` (3-part). ## Fix The `rpc_call` method in `packages/client/src/lib.rs` constructs `full_method = format!("{}.{}", self.domain, method)` before sending the JSON-RPC request. This was implemented in commit c75a0c6 but pushed directly to development without a PR. This issue documents it retroactively so it can go through proper review.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_rpc#3
No description provided.