RPC client should prefix method names with domain for 3-part dispatch #3
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_rpc#3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The OsisClient's
rpc_callmethod needs to prefix method names with the domain name to produce the 3-partdomain.Type.methodformat expected by the Unix socket dispatch.Without this, service calls like
authservice.get_challengeare sent as-is (2-part), but the raw Unix socket dispatcher expectsidentity.authservice.get_challenge(3-part).Fix
The
rpc_callmethod inpackages/client/src/lib.rsconstructsfull_method = format!("{}.{}", self.domain, method)before sending the JSON-RPC request.This was implemented in commit
c75a0c6but pushed directly to development without a PR. This issue documents it retroactively so it can go through proper review.