hero_proxy_server still imports removed HeroLog #52

New issue

Closed

opened 2026-05-12 15:05:58 +00:00 by zaelgohary · 1 comment

zaelgohary commented

2026-05-12 15:05:58 +00:00

Member

herolib_core::base::HeroLog was removed upstream; hero_proxy_server still uses it:

error[E0432]: unresolved import `herolib_core::base::HeroLog`
  --> crates/hero_proxy_server/src/main.rs:11:5
   |
11 | use herolib_core::base::HeroLog;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `HeroLog` in `base`

Commit 529836e fix(hero_proxy_admin): replace herolib_core::base::HeroLog with logger migrated hero_proxy_admin but missed hero_proxy_server. Same migration is needed: switch to herolib_core::logger.

Blocks every rebuild of hero_proxy on herodev (/home/zainab/hero/bin/hero_proxy* is currently 48h+ stale).

`herolib_core::base::HeroLog` was removed upstream; `hero_proxy_server` still uses it: ``` error[E0432]: unresolved import `herolib_core::base::HeroLog` --> crates/hero_proxy_server/src/main.rs:11:5 | 11 | use herolib_core::base::HeroLog; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `HeroLog` in `base` ``` Commit `529836e fix(hero_proxy_admin): replace herolib_core::base::HeroLog with logger` migrated `hero_proxy_admin` but missed `hero_proxy_server`. Same migration is needed: switch to `herolib_core::logger`. Blocks every rebuild of hero_proxy on herodev (/home/zainab/hero/bin/hero_proxy* is currently 48h+ stale).