add list_messages RPC to remove client-side N+1 #26

New issue

Closed

opened 2026-04-19 08:25:32 +00:00 by zaelgohary · 0 comments

zaelgohary commented

2026-04-19 08:25:32 +00:00

Member

Clients that want all messages for one conversation currently have to call chatmessage.list (returns every message SID in the entire domain) and then fetch each one via chatmessage.get, discarding any whose conversation_sid doesn't match. For a modestly-populated DB (~200 messages across ~10 chats) this is ~200 JSON-RPC round trips to open a single conversation.

Proposed fix: expose a ConversationService.list_messages(conversation_sid: str) -> [ChatMessage] RPC that filters server-side and returns messages sorted by created_at ascending. Measured outcome in the messaging UI: chat open drops from ~51 RPCs to 3.

The ChatMessage.conversation_sid field is already marked [index] in the schema; a later follow-up could switch the impl to a true indexed lookup instead of the current O(N) scan.

Clients that want all messages for one conversation currently have to call `chatmessage.list` (returns every message SID in the entire domain) and then fetch each one via `chatmessage.get`, discarding any whose `conversation_sid` doesn't match. For a modestly-populated DB (~200 messages across ~10 chats) this is **~200 JSON-RPC round trips** to open a single conversation. **Proposed fix**: expose a `ConversationService.list_messages(conversation_sid: str) -> [ChatMessage]` RPC that filters server-side and returns messages sorted by `created_at` ascending. Measured outcome in the messaging UI: chat open drops from ~51 RPCs to 3. The `ChatMessage.conversation_sid` field is already marked `[index]` in the schema; a later follow-up could switch the impl to a true indexed lookup instead of the current O(N) scan.

zaelgohary referenced this issue from a commit

2026-04-19 08:26:32 +00:00

communication: add list_messages RPC and stamp message timestamps

~~zaelgohary referenced this issue 2026-04-19 08:26:46 +00:00~~

communication: list_messages + stamp timestamps #27

zaelgohary referenced this issue

2026-04-19 08:31:56 +00:00

communication: list_messages + stamp timestamps #27

zaelgohary changed title from ~~perf: add ConversationService.list_messages(conversation_sid) to remove client-side N+1~~ to add list_messages RPC to remove client-side N+1

2026-04-19 08:32:18 +00:00

zaelgohary referenced this issue from a commit

2026-04-19 09:26:04 +00:00

tests: end-to-end messaging regression

~~zaelgohary referenced this issue from lhumina_code/hero_os 2026-04-19 09:26:23 +00:00~~

tests: end-to-end messaging regression #71

zaelgohary closed this issue

2026-04-19 09:27:33 +00:00

zaelgohary referenced this issue from a commit

2026-04-19 09:43:36 +00:00

tests: end-to-end messaging regression