fix: port standardization per hero_ports registry #3

Open
mik-tf wants to merge 6 commits from development_mik into development
Owner

Summary

  • Update default listen address to 127.0.0.1:3394
  • Update default Redis URL to port 3378
  • Include Redis auth in default connection URL
  • Standardize hero_os port reference to 8880

Test plan

  • hero_launcher starts on port 3394
  • Connects to hero_redis on port 3378

Consolidated from #2 into development_mik branch (includes latest development merged in).

## Summary - Update default listen address to 127.0.0.1:3394 - Update default Redis URL to port 3378 - Include Redis auth in default connection URL - Standardize hero_os port reference to 8880 ## Test plan - [ ] hero_launcher starts on port 3394 - [ ] Connects to hero_redis on port 3378 --- Consolidated from #2 into `development_mik` branch (includes latest `development` merged in).
fix: standardize hero_os port to 8880 (88xx frontend convention)
All checks were successful
Build and Test / build-and-test (pull_request) Successful in 5m57s
2e1f7cd34e
- Replace hero_wasmos references with hero_os
- Align all port references to 8880 (was 3388/8201)
- hero_wasmos is archived, hero_os is the active frontend
fix: update default listen to 127.0.0.1:3394 and redis to port 3378 per hero_ports registry
All checks were successful
Build and Test / build-and-test (pull_request) Successful in 5m42s
94da84a8a5
fix: include hero_redis auth in default redis URL
All checks were successful
Build and Test / build-and-test (pull_request) Successful in 5m53s
eae5299333
fix: don't pass extra CMD arg to Docker container
All checks were successful
Build and Test / build-and-test (pull_request) Successful in 5m51s
6a1ac0837a
The Dockerfile ENTRYPOINT is ["hero_zero", "run"]. Passing "hero_zero"
as CMD made the effective command "hero_zero run hero_zero", which
treated "hero_zero" as an unknown service name filter.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: disable admin UI in hero containers to avoid port conflicts
All checks were successful
Build and Test / build-and-test (pull_request) Successful in 4m57s
282c0fc062
Pass --admin-port 0 to hero_zero inside containers since --network host
shares the host's port space and the admin UI port would conflict.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: poll container status and transition from initializing to running
All checks were successful
Build and Test / build-and-test (pull_request) Successful in 7m7s
6f0ff9abbf
After launching a container, poll its status every 2s for up to 60s.
Transition to Running when container is up, or Error if it exits
or times out. Previously status was stuck on Initializing forever.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
All checks were successful
Build and Test / build-and-test (pull_request) Successful in 7m7s
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin development_mik:development_mik
git switch development_mik

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development
git merge --no-ff development_mik
git switch development_mik
git rebase development
git switch development
git merge --ff-only development_mik
git switch development_mik
git rebase development
git switch development
git merge --no-ff development_mik
git switch development
git merge --squash development_mik
git switch development
git merge --ff-only development_mik
git switch development
git merge development_mik
git push origin development
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_launcher!3
No description provided.