feat: Add install script, uninstall script, and CI test workflow #64

Merged

mahmoud merged 11 commits from development_install_ci into development 2026-04-07 09:20:22 +00:00

Conversation 0 Commits 11 Files changed 4 +598 -161

mahmoud commented 2026-04-06 15:04:59 +00:00

Owner

Copy link

Summary

• Install script (scripts/install.sh): Single-command installer that downloads pre-built binaries (cloud-hypervisor, mycelium, hero_proc, my_hypervisor, hero_compute), installs system dependencies, and starts all services. Safe to re-run — checks each component and only downloads what's missing or outdated. Supports --env flag for environment selection.
• Uninstall script (scripts/uninstall.sh): Clean removal of all installed components.
• CI workflow (.forgejo/workflows/test-install.yaml): Forgejo Actions workflow that tests the install script in a container environment — verifies binary downloads, dependency installation, and service startup.

Changes

File	Description
scripts/install.sh	Single-command installer with progress output, version checks, graceful package handling
scripts/uninstall.sh	Uninstall script for clean removal
.forgejo/workflows/test-install.yaml	CI workflow to test the install script

Install usage

# Default (development environment)
curl -sfL https://forge.ourworld.tf/lhumina_code/hero_compute/raw/branch/development/scripts/install.sh | bash

# Specific environment
curl -sfL https://forge.ourworld.tf/lhumina_code/hero_compute/raw/branch/development/scripts/install.sh | bash -s -- --env production

Test plan

• CI workflow passes in container environment
• Install script downloads all binaries correctly
• Install script handles missing system packages gracefully
• Uninstall script removes all components
• Re-running install script is idempotent

Related issues

• #63

## Summary - **Install script** (`scripts/install.sh`): Single-command installer that downloads pre-built binaries (cloud-hypervisor, mycelium, hero_proc, my_hypervisor, hero_compute), installs system dependencies, and starts all services. Safe to re-run — checks each component and only downloads what's missing or outdated. Supports `--env` flag for environment selection. - **Uninstall script** (`scripts/uninstall.sh`): Clean removal of all installed components. - **CI workflow** (`.forgejo/workflows/test-install.yaml`): Forgejo Actions workflow that tests the install script in a container environment — verifies binary downloads, dependency installation, and service startup. ## Changes | File | Description | |------|-------------| | `scripts/install.sh` | Single-command installer with progress output, version checks, graceful package handling | | `scripts/uninstall.sh` | Uninstall script for clean removal | | `.forgejo/workflows/test-install.yaml` | CI workflow to test the install script | ## Install usage ```bash # Default (development environment) curl -sfL https://forge.ourworld.tf/lhumina_code/hero_compute/raw/branch/development/scripts/install.sh | bash # Specific environment curl -sfL https://forge.ourworld.tf/lhumina_code/hero_compute/raw/branch/development/scripts/install.sh | bash -s -- --env production ``` ## Test plan - [x] CI workflow passes in container environment - [x] Install script downloads all binaries correctly - [x] Install script handles missing system packages gracefully - [x] Uninstall script removes all components - [x] Re-running install script is idempotent ### Related issues - https://forge.ourworld.tf/lhumina_code/hero_compute/issues/63

mahmoud added 3 commits 2026-04-06 15:04:59 +00:00

ci: add install script test workflow ... 63dbc52556

Adds a Forgejo Actions workflow that tests scripts/install.sh via
curl | bash on both Ubuntu 22.04 and Alpine 3.19 containers.

Tests: binary installation, service startup, clean shutdown, and
idempotent re-run. Scoped to development_install_ci branch for
validation before merging.

#63

fix: handle unavailable system packages gracefully in install script ... 1418726745

Install packages one-by-one so that unavailable packages (e.g.
virtiofsd on Ubuntu 22.04) don't abort the entire installation.
Missing packages are logged as warnings instead of fatal errors.

#63

ci: retrigger install test workflow 50a9238ca6

mahmoud added 1 commit 2026-04-06 15:06:39 +00:00

ci: add workflow description comment to trigger CI 66eaa6125a

mahmoud added 1 commit 2026-04-06 15:22:54 +00:00

fix: correct CI binary list and skip hardware checks in CI ... fc3533d70b

- Fix binary list: use actual binaries from config
  (hero_proc, hero_proc_server, hero_proc_ui)
- Skip kernel extraction and hypervisor doctor checks when CI=true
  (no KVM, no kernel, no virtiofsd in containers)
- Set CI=true env var in workflow steps

#63

mahmoud added 1 commit 2026-04-06 15:25:09 +00:00

fix: rework CI service checks for container environments ... 714f694636

Instead of expecting daemons to run (needs KVM, TUN, sockets):
- Verify binaries respond to --version/--help (proves downloads valid)
- Start hero_proc_server, confirm PID alive, then stop and confirm clean shutdown
- Skip mycelium daemon test (needs TUN), verify --help instead

#63

mahmoud added 1 commit 2026-04-06 15:38:25 +00:00

docs: document --env flag for curl | bash usage ... c2e30b8485

Add bash -s -- --env examples to install script header and setup guide.

#63

mahmoud added 1 commit 2026-04-06 15:42:42 +00:00

feat: add progress dots and install log for long-running steps ... d5d2b9659a

- Package installs show progress dots while running in background
- Binary downloads show progress dots with filename
- Full output logged to ~/hero/log/install.log
- Log path shown at start and in final summary

#63

mahmoud added 1 commit 2026-04-06 15:43:39 +00:00

feat: Update hero_compute_sdk for HTTP RPC over UDS ... fc77d93045

- Add functions for generating socket paths
- Introduce http_rpc_unix for HTTP RPC over UDS
- Remove raw_rpc_unix and related constants

mahmoud added 1 commit 2026-04-06 15:48:02 +00:00

feat: polish install script output and add uninstall script ... c0be39f116

Install script improvements:
- Color output (green/yellow/red) with unicode symbols
- Box-drawn header and summary
- Progress dots with done/failed status for every operation
- Download labels show component name instead of temp filenames
- All output logged to ~/hero/log/install.log
- Services show running/stopped status in summary
- Consistent indentation and alignment throughout

New uninstall script (scripts/uninstall.sh):
- Stops all services, removes binaries, data, config, PATH entries
- Removes system packages (virtiofsd, busybox-static)
- Removes my_hypervisor network interface
- Verification step confirms clean state
- Supports curl | bash for remote execution

#63

mahmoud added 1 commit 2026-04-06 15:50:49 +00:00

refactor: Update to use hero_compute_sdk for RPC ... 8948b18cd2

- Use hero_compute_sdk for socket path resolution
- Update RPC calls to use HTTP/1.1 over Unix sockets/TCP
- Remove direct UnixStream and TcpStream usage for RPC
- Update imports and dependencies
- Add hero_compute_sdk to Cargo.toml

mahmoud added 1 commit 2026-04-06 16:01:12 +00:00

fix: suppress interactive apt prompts during install ... ca2e1253ac

Set DEBIAN_FRONTEND=noninteractive and force-confdef/force-confold
dpkg options to prevent needrestart and config file prompts from
blocking the installer (especially virtiofsd on Ubuntu 24.04).

#63

mahmoud added 1 commit 2026-04-06 16:09:42 +00:00

fix: mycelium peer args and early PATH setup ... cac6ca7ae9

- mycelium --peers expects space-separated args, not comma-separated
  single string (was causing 'invalid socket address syntax' error)
- Add ~/hero/bin to PATH early in install so my_hypervisor doctor
  can find cloud-hypervisor during installation

#63

mahmoud added 1 commit 2026-04-06 16:18:23 +00:00

feat(sockets): align with Hero Socket Convention -- HTTP over UDS + standardized layout ... 9805acfc8b

Migrate hero_compute from raw newline-delimited JSON-RPC via UnixRpcServer
to HTTP-over-UDS via AxumRpcServer with standardized socket directory layout
under $HERO_SOCKET_DIR/hero_compute/.

Socket layout:
  - rpc.sock (server)
  - ui.sock (dashboard)
  - explorer_rpc.sock (explorer)

#65

mahmoud added 1 commit 2026-04-06 16:48:15 +00:00

fix(sdk): add connect_server_socket for correct AxumRpcServer RPC path ... 29399f568c

The generated connect_socket() sends HTTP POST to /rpc, but AxumRpcServer
serves at /api/root/cloud/rpc. Add connect_server_socket() that uses
unix_socket_with_path() with the correct path.

Also add protocol: "openrpc" to heroservice.json for hero_router discovery.

#65

mahmoud added 1 commit 2026-04-06 18:09:36 +00:00

docs: update all documentation for HTTP-over-UDS socket convention ... c51b8a77e1

- Replace all references to old socket names (hero_compute_server.sock, etc.)
  with new layout (hero_compute/rpc.sock, ui.sock, explorer_rpc.sock)
- Update protocol descriptions from "raw JSON-RPC newline-delimited" to
  "HTTP/1.1 JSON-RPC 2.0 over UDS"
- Replace socat examples with curl --unix-socket examples
- Standardize explorer socket env var to HERO_COMPUTE_EXPLORER_SOCKET
- Update mermaid diagrams in architecture.md

#65

mahmoud added 1 commit 2026-04-06 18:18:00 +00:00

style: apply rustfmt formatting ... 53a54f2b93

#65

mahmoud force-pushed development_install_ci from 53a54f2b93 to ec27ebebc4 2026-04-06 18:34:49 +00:00 Compare

mahmoud changed title from CI workflow to test single line installer to feat: Add install script, uninstall script, and CI test workflow 2026-04-06 18:42:11 +00:00

mahmoud referenced this pull request 2026-04-06 18:42:34 +00:00

feat: Add single-command install script, uninstall script, and CI workflow #68

mahmoud added 1 commit 2026-04-06 18:54:21 +00:00

chore: finalize CI workflow targets and docs before merge ... 7b350f5f87

- Update test-install.yaml to target development/main branches
- Add --env flag documentation to setup.md

mahmoud added 1 commit 2026-04-06 18:57:30 +00:00

fix: set FORGE_TOKEN and WEBROOT defaults when starting hero_proc_server ... e365fa84a3

hero_proc_server v0.4.4 requires FORGE_TOKEN and WEBROOT env vars
on startup. Set sensible defaults so the installer can start the
service. Users can configure the real token later.

mahmoud added 1 commit 2026-04-06 19:03:51 +00:00

fix: address all review findings for install/uninstall/CI ... 40ac805515

Install script (scripts/install.sh):
- Replace set -e with set -u to prevent silent exits from background
  process failures; all errors now handled explicitly with return codes
- Add --connect-timeout 10 --max-time 120 --retry 2 to all curl calls
- Show download URL to user on failure (not just in log file)
- Every download() caller now checks return code and handles failure
  gracefully (skip component, not crash entire install)
- Tighten version grep with word-boundary anchoring to prevent
  0.1.3 matching 0.1.30
- Fix printf format strings: use %b for ANSI escapes consistently,
  never embed escape codes in format string position
- Extract _hero_proc_socket_exists helper to avoid path duplication
- Extract _wait_with_dots helper to reduce code duplication
- Rename mycelium peers variable to peers_list for clarity
- Add FORGE_TOKEN to --help output

Uninstall script (scripts/uninstall.sh):
- Replace pgrep -f with pgrep -x for exact process name matching,
  falling back to full-path match only for ~/hero/bin/ binaries
- Check reverse dependencies before removing system packages
  (apt-cache rdepends) to avoid breaking shared packages
- Fix printf format strings for consistent ANSI handling
- Use set -u instead of set -e

CI workflow (.forgejo/workflows/test-install.yaml):
- Set FORGE_TOKEN and WEBROOT as job-level env vars
- Consolidate binary existence + response checks into single step
  (reduces duplication between Ubuntu and Alpine jobs)
- Add FORGE_TOKEN/WEBROOT to service start/stop test step
- Branch triggers already set to development/main

mahmoud added 1 commit 2026-04-07 08:43:13 +00:00

fix: update stale versions in configure.sh ... 9b86da41dd

- cloud-hypervisor: v43.0 → v50.0
- my_hypervisor: v0.1.2 → v0.1.4

These defaults were out of sync with the central config.

mahmoud added 1 commit 2026-04-07 08:46:18 +00:00

fix: show PATH export command in post-install summary ... 036bfbd41f

After curl | bash, ~/hero/bin is added to .bashrc but not the
current shell. Print the export command so the user can copy-paste
it immediately.

mahmoud added 1 commit 2026-04-07 08:47:45 +00:00

merge: bring in latest development changes ed2c3f058e

mahmoud added 1 commit 2026-04-07 09:03:55 +00:00

ci: remove Alpine job from install test workflow 03b50499ab

mahmoud added 1 commit 2026-04-07 09:09:45 +00:00

chore: fix comment — Ubuntu only ec8652cfa5

mahmoud added 1 commit 2026-04-07 09:13:19 +00:00

merge: resolve conflict in configure.sh — keep development version (central config) 171eed46a3

mahmoud added 1 commit 2026-04-07 09:17:33 +00:00

fix: prompt for user confirmation even via curl | bash ... 674790c0e6

Read from /dev/tty instead of stdin so the y/N prompt works when
the script is piped (curl | bash). Skip in CI where no TTY exists.

mahmoud merged commit 5f788f2658 into development 2026-04-07 09:20:22 +00:00

mahmoud referenced this pull request from a commit 2026-04-07 09:20:23 +00:00

feat: Add install script, uninstall script, and CI test workflow (#64)

mahmoud deleted branch development_install_ci 2026-04-07 09:20:28 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

prio_critical

  

prio_low

  

type_bug

  

type_contact

  

type_issue

  

type_lead

  

type_question

  

type_story

  

type_task

No labels

prio_critical

prio_low

type_bug

type_contact

type_issue

type_lead

type_question

type_story

type_task

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_compute!64

No description provided.