fix: align build system with skills and add three-tier local CI #61

Open

mik-tf wants to merge 0 commits from development_mik into development

pull from: development_mik

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:cleanup/remove-deps-txt

lhumina_code:main

Conversation 0 Commits - Files changed -

mik-tf commented 2026-02-19 03:02:04 +00:00

Owner

Copy link

Align build system with makefile_helper and forge_ci skills, add three-tier local CI, and fix pre-existing clippy/fmt issues.

Changes

• test-all.sh calls make targets instead of raw cargo commands
• Add separate fmt-check and lint Makefile targets
• CI test.yaml simplified to make test-all (test job: SKIP_SMOKE=1, integration job: full suite)
• Add ci-local, ci-docker, ci-patch-deps.sh scripts
• Fix clippy: collapsible_if, sort_by_key, duplicated cfg(test) attrs
• cargo fmt on pre-existing formatting issues
• buildenv.sh version 0.1.4 -> 0.1.5
• Admin settings API (admin.settings.get/set RPC for AI key config)

Testing

• 120 unit tests pass
• fmt-check, clippy, check all clean
• Release build succeeds

Closes #59
Closes #56

---

Consolidated from #60 into development_mik branch (includes latest development merged in).

Closes #63

Align build system with makefile_helper and forge_ci skills, add three-tier local CI, and fix pre-existing clippy/fmt issues. ## Changes - test-all.sh calls make targets instead of raw cargo commands - Add separate fmt-check and lint Makefile targets - CI test.yaml simplified to `make test-all` (test job: SKIP_SMOKE=1, integration job: full suite) - Add ci-local, ci-docker, ci-patch-deps.sh scripts - Fix clippy: collapsible_if, sort_by_key, duplicated cfg(test) attrs - cargo fmt on pre-existing formatting issues - buildenv.sh version 0.1.4 -> 0.1.5 - Admin settings API (admin.settings.get/set RPC for AI key config) ## Testing - 120 unit tests pass - fmt-check, clippy, check all clean - Release build succeeds Closes #59 Closes #56 --- Consolidated from #60 into `development_mik` branch (includes latest `development` merged in). Closes #63

mik-tf added 7 commits 2026-02-19 03:02:04 +00:00

feat: add admin.settings.get/set RPC for AI key configuration ... a23e321c5e

Adds persistent AI settings store at ~/hero/var/hero_books/settings.toml
with two new admin RPC endpoints:
- admin.settings.get: returns masked key status per provider (Groq, OpenRouter, SambaNova) + embedder URL
- admin.settings.set: updates keys, persists to disk, applies to process env

Settings are loaded and applied to env on startup (before AiClient::from_env),
with env vars as fallback when no saved setting exists.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/development' into development_books_settings_api baab3b911f

fix: update CI deps.txt for hero_rpc_osis migration ... 0f929f4a76

After the herolib_osis → hero_rpc_osis migration (development),
deps.txt was not updated. CI failed because the patching system
could not resolve hero_rpc_osis without hero_rpc.git listed.

- Add hero_rpc.git with hero_rpc_osis=packages/osis
- Remove stale herolib_osis entry from hero_lib.git line

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: complete herolib_osis → hero_rpc_osis migration in generated code ... 64d7417bde

The migration commit left 13 herolib_osis references in generated files:
- types_generated.rs: 2 import statements
- osis_server_generated.rs: 11 references (imports, trait impls, types)

Also fix 4 clippy collapsible_if warnings in settings.rs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/development_books_settings_api' into development_build_ci_consolidation 8f244fc58a

fix: align build system with skills, add three-tier CI, fix clippy/fmt ... 67b7d0e870

Build system alignment (per makefile_helper skill):
- test-all.sh uses make targets (fmt-check, lint, check, test, build)
  instead of raw cargo commands
- Add separate fmt-check and lint targets (was combined in fmt)
- Add ci-local, ci-docker targets with scripts
- CI test.yaml simplified: test job runs SKIP_SMOKE=1 make test-all,
  integration job runs full make test-all
- ci-patch-deps.sh replaces inline deps patching in CI workflow

Three-tier local CI:
- make test-all: quick offline checks (~80% fidelity)
- make ci-local: no workspace config overrides (~95% fidelity)
- make ci-docker: same Docker image as CI (~100% fidelity)

Code fixes:
- Fix clippy: collapsible_if, sort_by_key, duplicated cfg(test) attrs
- Run cargo fmt on all pre-existing formatting issues
- Fix buildenv.sh version mismatch (0.1.4 -> 0.1.5)

Tested: fmt-check, clippy, check, 120 tests, release build — all pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: install Playwright browsers before make test-all in CI ... b25708fb52

The integration job installed npm but not Playwright browsers. test-all.sh
detects npx is available and tries to run E2E tests, but the browser binary
is missing. Split into separate steps: install Playwright first, then run
make test-all.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf referenced this pull request 2026-02-19 03:02:05 +00:00

fix: align build system with skills and add three-tier local CI #60

mik-tf added 1 commit 2026-02-19 12:19:09 +00:00

chore: remove unused cross-repo dep patching ... 8b876b0487

The deps.txt + ci-patch-deps.sh system was never wired into the actual
CI workflow (build.yaml). Cross-repo deps are handled by workspace
.cargo/config.toml paths locally, and by git deps in CI directly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf referenced this pull request 2026-02-19 12:19:42 +00:00

chore: remove unused .forgejo/deps.txt #62

despiegk added 5 commits 2026-02-19 14:06:18 +00:00

feat: switch hero_embedder connection from HTTP to Unix socket ... d567603044

- Update all embedder_url defaults to use Unix socket at /Users/despiegk/hero/var/sockets/hero_embedder.sock
- Remove environment variable dependencies for embedder_url configuration
- Update documentation and comments to reflect Unix socket path
- Remove unused imports and constants
- Update test assertions to match new socket path
- Simplify EmbedderConfig, VectorStoreConfig, and EmbeddingConfig defaults

This enables hero_books to communicate with hero_embedder via local Unix socket for better performance and security.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add hero_embedder health check at startup ... 95ed3aa21e

- Verify hero_embedder socket exists before starting books service
- Fail fast with clear error messages if embedder is unavailable
- Add unix_socket utility module for socket URL handling
- Health check validates socket file existence and embedder responsiveness

This ensures hero_books won't start in a degraded state without embedder.

Note: The HeroEmbedderClient SDK from hero_embedder doesn't natively support
Unix socket URLs (unix://). A proper Unix socket client implementation is needed
to complete the socket-based communication.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

feat: add Unix socket HTTP client support infrastructure ... 6beb8b7960

- Add hyperlocal and hyper dependencies for Unix socket HTTP communication
- Implement unix_socket module with utilities:
  - Client type for Unix socket HTTP requests
  - Socket URL detection and parsing
  - Socket file existence verification
  - URI conversion for hyperlocal format

This provides the foundation for making HeroEmbedderClient work over Unix sockets.
The next step is to create a wrapper that intercepts HeroEmbedderClient calls
and routes unix:// URLs through the Unix socket HTTP client.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

fix: update hero_books socket path to match hero ecosystem ... d54b36e381

- Change hero_books socket from /tmp/hero_books.sock to /Users/despiegk/hero/var/sockets/hero_books.sock
- Ensures consistency with hero_embedder socket location
- Update startup banner to show correct socket path
- All sockets now centralized in hero/var/sockets directory

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

fix: update hero_embedder dep to include Unix socket SDK support ... 792d06836e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

despiegk added 1 commit 2026-02-19 15:14:36 +00:00

merge: integrate development branch ... 5daafb0bff

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

despiegk added 1 commit 2026-02-19 15:15:10 +00:00

fix: update generated code and tests after development merge ... 41d71ee98d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

despiegk added 2 commits 2026-02-22 03:17:55 +00:00

refactor: enforce hero crates best practices — SDK Unix socket, dark UI with tabs ... bb3a7013b2

- SDK: replace reqwest HTTP with Unix socket transport (tokio UnixStream)
- UI: convert from Dioxus WASM to Axum+HTML admin panel using SDK
- UI: dark theme by default with tabbed navigation (Libraries, Collections, Import, Health)
- Server: fix Unix socket handler to properly serve HTTP via hyper 1.x
- CLI + Rhai: update to use SDK Unix socket client
- Makefile: unified `make run` starts server then UI, proper stop/cleanup
- buildenv.sh: add hero_books_ui binary and port 8884
- README: update architecture, ports, sockets, dependency graph
- build.rs: add template rebuild detection

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update Rust toolchain to 1.93 and bump dependency versions ... 9d6ad6d520

Upgrade rust-toolchain from 1.92.0 to 1.93 and update Cargo.lock
with latest crate versions (syn 2.0.117, clap 4.5.60, wasm-bindgen
0.2.111, security-framework 3.7.0, and others).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

despiegk added 1 commit 2026-02-22 07:25:13 +00:00

feat: implement UI RPC proxy pattern — JS calls /rpc directly for all operations ... 37c440850b

Templates now load data client-side via rpc() JS helper instead of server-side Rust handlers.
SDK gains a public call() method for raw JSON-RPC forwarding.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Some checks failed

Hide all checks

Test / test (pull_request) Failing after 3s

Details

Test / integration (pull_request) Has been skipped

Details

Test / test (push) Failing after 2s

Details

Test / integration (push) Has been skipped

Details

Build Linux / build-linux (linux-amd64, x86_64-unknown-linux-gnu) (push) Failing after 5m45s

Details

This branch is already included in the target branch. There is nothing to merge.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin development_mik:development_mik

git switch development_mik

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff development_mik

git switch development_mik

git rebase development

git switch development

git merge --ff-only development_mik

git switch development_mik

git rebase development

git switch development

git merge --no-ff development_mik

git switch development

git merge --squash development_mik

git switch development

git merge --ff-only development_mik

git switch development

git merge development_mik

git push origin development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_books!61

No description provided.