lhumina_code/hero_books

CI fix: clippy + fmt; drop dead helpers in books_server #127

New issue

Closed

opened 2026-05-12 20:46:59 +00:00 by zaelgohary · 2 comments

zaelgohary commented

2026-05-12 20:46:59 +00:00

Member

CI was failing on Format and Clippy. cargo fmt + cargo clippy --fix sweep. Manual collapsible_if fix in components/home.rs. cloned_ref->slice::from_ref. Deleted unused BlockOnRuntime, parse_hero_file, parse_hero_key_values, derive_git_url_from_repo_path in books_server/web/server.rs.

CI was failing on Format and Clippy. cargo fmt + cargo clippy --fix sweep. Manual collapsible_if fix in components/home.rs. cloned_ref->slice::from_ref. Deleted unused BlockOnRuntime, parse_hero_file, parse_hero_key_values, derive_git_url_from_repo_path in books_server/web/server.rs.

zaelgohary self-assigned this

2026-05-12 20:46:59 +00:00

zaelgohary commented

2026-05-12 20:46:59 +00:00

Author

Member

Fix pushed: c1b88bb5

Fix pushed: c1b88bb5

zaelgohary commented

2026-05-12 21:07:22 +00:00

Author

Member

Follow-up fix: 890accff drops call to missing scripts/smoke-test.sh in integration job.

Follow-up fix: 890accff drops call to missing scripts/smoke-test.sh in integration job.

zaelgohary closed this issue

2026-05-12 21:19:52 +00:00

timur referenced this issue from a commit

2026-05-13 08:17:35 +00:00

refactor(server): adopt per-domain SDK clients (#127)

Sign in to join this conversation.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_books#127

No description provided.