Clean up clippy suppressions and restore excluded WASM crates #26

New issue

Open

opened 2026-02-24 03:43:22 +00:00 by mik-tf · 0 comments

mik-tf commented

2026-02-24 03:43:22 +00:00

Owner

Context

The CI fix (PR #25) added several #[allow(clippy::...)] suppressions to make clippy pass. While the CI infrastructure is now correct, a few of these suppressions mask code that should be properly refactored. Additionally, two example crates (os_widgets, os_components) were excluded from the WASM check because they broke against the updated hero_osis_sdk API.

Goals

Refactor upload_and_create_song in archipelagos/library/songs/src/services/mod.rs to accept a CreateSongRequest struct instead of 8 positional arguments, removing the too_many_arguments allow
Investigate Role type alias and AVAILABLE_MODELS constant in archipelagos/intelligence/intelligence/src/views/roles/role_editor.rs — delete if unused, keep allow if intentionally reserved
Update os_widgets and os_components to work with the current hero_osis_sdk BaseClient API, then re-include them in the WASM check in build.yaml

## Context The CI fix (PR #25) added several `#[allow(clippy::...)]` suppressions to make clippy pass. While the CI infrastructure is now correct, a few of these suppressions mask code that should be properly refactored. Additionally, two example crates (os_widgets, os_components) were excluded from the WASM check because they broke against the updated hero_osis_sdk API. ## Goals - Refactor `upload_and_create_song` in `archipelagos/library/songs/src/services/mod.rs` to accept a `CreateSongRequest` struct instead of 8 positional arguments, removing the `too_many_arguments` allow - Investigate `Role` type alias and `AVAILABLE_MODELS` constant in `archipelagos/intelligence/intelligence/src/views/roles/role_editor.rs` — delete if unused, keep allow if intentionally reserved - Update `os_widgets` and `os_components` to work with the current `hero_osis_sdk` `BaseClient` API, then re-include them in the WASM check in `build.yaml`