Add admin dashboard, per-IP metrics, and ecosystem standardization #5

Closed

mik-tf wants to merge 23 commits from development_hero_zero_standardize into development

pull from: development_hero_zero_standardize

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:main

Conversation 2 Commits 23 Files changed 84 +4075 -1926

mik-tf commented 2026-02-11 21:04:08 +00:00

Owner

Copy link

Full admin dashboard with model management, chat testing, MCP tools, API keys, logs, and API docs. Adds per-IP request metrics and aligns the service with hero ecosystem conventions.

Changes

• Admin dashboard UI (merged from development_ui_enhancements branch) — Bootstrap 5.3.3, 8 tabs, dark theme, hero_auth JWT integration
• Per-IP metrics middleware on all /v1/* routes (replaces global-only counter)
• Dynamic API docs rendered from /openrpc.json (replaces hardcoded HTML)
• Port 3751 → 3385, binary renamed to hero_aibroker per ecosystem registry
• Makefile rewritten per makefile_helper skill
• API key loading accepts both singular and plural env var forms

Testing

• 12 smoke tests pass
• cargo build --release and cargo clippy clean

Closes #6

Full admin dashboard with model management, chat testing, MCP tools, API keys, logs, and API docs. Adds per-IP request metrics and aligns the service with hero ecosystem conventions. ## Changes - Admin dashboard UI (merged from `development_ui_enhancements` branch) — Bootstrap 5.3.3, 8 tabs, dark theme, hero_auth JWT integration - Per-IP metrics middleware on all `/v1/*` routes (replaces global-only counter) - Dynamic API docs rendered from `/openrpc.json` (replaces hardcoded HTML) - Port 3751 → 3385, binary renamed to `hero_aibroker` per ecosystem registry - Makefile rewritten per makefile_helper skill - API key loading accepts both singular and plural env var forms ## Testing - 12 smoke tests pass - `cargo build --release` and `cargo clippy` clean Closes #6

mik-tf added 15 commits 2026-02-11 21:04:08 +00:00

compliance: register port 3385, remove dotenvy, fix build_lib header ... ecb045fad9

- Register aibroker at port 3385 in hero_ports (was unregistered 3751)
- Remove dotenvy crate (env_secrets: use source ~/.config/env.sh)
- Fix build_lib.sh header (was hero_redis copy-paste)
- Fix .env.example: HOST=127.0.0.1, PORT=3385 (was 0.0.0.0:8080)
- Remove --env-file .env from docker-run target
- Update openrpc.json server URL to port 3385

feat: add rpc.discover JSON-RPC method ... f75a690c1a

- Add rpc.discover to RPC dispatcher (returns OpenRPC spec)
- Add rpc.discover method to openrpc.json spec
- Enables automatic service discovery (heroindex pattern)

feat: hero_ui_dashboard alignment — Bootstrap 5.3.3, theme toggle, auth, SSE ... 40d2e16a76

- Bootstrap 5.3.3 + Bootstrap Icons 1.11.3 CDN
- Flat navbar (bg-body-tertiary border-bottom), no gradient/!important
- Dark/light theme toggle with localStorage and iframe sync
- Status dots (.status-ok/.status-warn/.status-error/.status-off)
- Tab IDs: tab-chat, tab-models, tab-mcp, tab-apikeys, tab-metrics, tab-logs, tab-apidocs
- Sidebar cards: card mb-3 with card-header/card-body
- Tab content wrapper: border border-top-0 rounded-bottom p-3
- Compact sizing (0.85rem)
- Removed all hardcoded bg-dark/text-white/border-secondary from templates
- CSS variables (var(--bs-*)) instead of hardcoded colors
- Admin auth middleware (ADMIN_TOKEN bearer check, optional)
- SSE endpoint at /api/events (replaces 10s polling)
- Broadcast channel for server-sent events
- Auth token in rpcCall headers from localStorage

test: add smoke tests and CI smoke test step ... 71fe04605e

- scripts/smoke-test.sh: comprehensive smoke test suite
  - Basic mode: health, openrpc, admin HTML, RPC methods, SSE, OpenAI models, 404
  - Auth mode: token validation, 401/403 checks, public vs admin routes
- CI: add smoke test step after build (start server, run tests, cleanup)

fix: align admin UI with hero_ui_dashboard skill ... b4278c1392

- Navbar: bi-diagram-3 brand icon, SSE dot+text, .vr dividers, logout btn
- Favicon: SVG file with diagram-3 icon on blue background, served before auth
- Tabs: <button> with data-bs-target (not <a> with href), Bootstrap Icons
- Sidebar cards: d-flex headers with icons and refresh button
- Container: py-4 (not p-2)
- Status CSS: custom --status-ok/warn/error root vars
- Theme: aibroker_theme localStorage key, updateThemeIcon(), d-none default
- Compact sizing: all form-control, form-select, btn, table rules
- JS tab handler: uses data-bs-target, stops logs on tab switch
- Smoke tests: favicon route tests (23 total)

feat: add hero_auth integration (HERO_SECRET JWT + HERO_AUTH_URL OAuth) ... 16a69e4b01

Backend:
- Add jsonwebtoken v9 dependency for HS256 JWT validation
- New auth.rs module: Claims, AuthError, validate_admin_token(), extract_bearer_token()
- Dual auth chain in admin_auth middleware: ADMIN_TOKEN (simple) then HERO_SECRET (JWT)
- Config loads HERO_SECRET and HERO_AUTH_URL from env vars
- Dashboard HTML (/) served without auth so JS can handle login redirects
- Only /rpc and /api/events remain auth-protected
- IndexTemplate passes hero_auth_url to Askama template

Frontend (base.html):
- HERO_AUTH_URL injected via Askama template variable in <head>
- Early auth init (IIFE before DOMContentLoaded): OAuth callback, localStorage, redirect
- handleAuthError() clears token and redirects to hero_auth on 401/403
- Redirect loop prevention via authRedirectInProgress flag
- Logout button wired: clear localStorage + redirect with ?logout=true
- rpcCall() checks auth before request, handles auth errors in response
- Token expiry tracking via aibroker_token_expiry localStorage key

Tests:
- 5 unit tests in auth.rs (valid token, wrong secret, insufficient scope, multi-scope, extract bearer)
- Smoke tests updated: dashboard no-auth 200, RPC auth checks, favicon no-auth
- 23/23 basic mode, 12/12 auth mode

test: add Playwright E2E tests and CI test workflow ... 4fa588bcf2

- Add 5 Playwright test files: navigation, dashboard, api, rpc, auth
- 43 tests (basic mode) + 10 tests (auth mode) = 53 total
- Add fixtures.ts with localStorage token injection
- Create test.yaml CI workflow (triggers on all branch pushes)
- Update build workflows to trigger only on tags (not branches)
- Add Makefile targets: test-smoke, test-smoke-auth, test-e2e, test-e2e-auth, test-full
- Add apikeys.db and e2e artifacts to .gitignore

style: cargo fmt — fix pre-existing formatting issues fd35495817

ci: scope clippy to llmbroker, allow pre-existing lint warnings 8a878dbdef

Rename llmbroker to aibroker per naming convention skill ... 1dd5f7dc6d

- Rename crates/llmbroker/ to crates/aibroker/
- Rename crates/llmbroker-cli/ to crates/aibroker_cli/ (snake_case)
- Update all Cargo.toml package/bin/dep names
- Update use statements, struct names, string literals
- Rename LlmBrokerExtension to AiBrokerExtension, x_llmbroker to x_aibroker
- Update buildenv.sh BINARIES, Makefile, CI workflows
- Rewrite README with current state (port 3385, hero_auth, make targets)
- Remove redundant build.yaml (replaced by test.yaml)
- Merge fmt/lint into single target per makefile_helper skill
- Rename rundev to dev per makefile_helper skill
- Update all docs/*.md references
- Fix workspace repo URL to forge.ourworld.tf

fix: dashboard auth, SSE, logout, theme toggle (hero_auth parity) ... 1f3ccc93ea

- Add query param token support to admin_auth middleware (EventSource
  cannot set Authorization headers, needs ?token= for SSE)
- Fix base.html JS: proper initAuth() with OAuth hash callback,
  localStorage persistence, token expiry handling
- Wire up logout button (clears token, redirects to hero_auth)
- Wire up theme toggle (localStorage persistence, parent frame sync)
- Fix SSE: use onopen handler, pass token via query param
- Add handleAuthError() to redirect to hero_auth on 401/403

fix: dashboard auth flow per hero_ui_dashboard skill ... 445e35eb17

- Early auth IIFE: check token before DOMContentLoaded, hide page and
  redirect to hero_auth immediately when no token (prevents flash)
- Handle 401 vs 403 separately: 401 clears token silently (no redirect
  from background polls), 403 redirects once then shows Access Denied
- Add sessionStorage scope retry tracking to prevent infinite 403 loop
- Add Auth navbar link (bi-shield-lock) when HERO_AUTH_URL is configured
- Extract clearAuthToken() and redirectToLogin() helpers
- Skip SSE init when no token available

feat: rename binary llmbroker -> hero_aibroker ... df83e858ef

- Rename llmbroker -> hero_aibroker (crates/llmbroker/Cargo.toml [[bin]])
- Update buildenv.sh BINARIES
- Update Makefile run/rundev targets
- Per naming_convention: binary matches service name in snake_case

standardize: port 3751→3385 per hero_ports registry 8fa6e50f17

Merge remote-tracking branch 'origin/development_ui_enhancements' into development_hero_zero_standardize ... 3f72bba71e

# Conflicts:
#	Makefile
#	buildenv.sh
#	crates/aibroker/Cargo.toml

mik-tf added 1 commit 2026-02-11 22:04:33 +00:00

fix: Makefile compliance - move scripting to scripts/ ... 094ecf9a00

- Move smoke tests, e2e tests, port stopping to scripts/
- Each Makefile target is now a thin wrapper
- Per makefile_helper skill

mik-tf added 1 commit 2026-02-12 00:11:51 +00:00

ci: restrict test triggers to PRs and push to development/main ... 53a8ed6e1f

Stop triggering test/build workflows on every push to every branch.
Tests now run only on:
- push to development or main (post-merge validation)
- pull_request targeting development or main (pre-merge check)
- manual workflow_dispatch

Per forge_ci skill: Standard Workflow Triggers convention.

mik-tf changed title from standardize: port 3385, binary name hero_aibroker, merge UI enhancements to WIP: standardize: port 3385, binary name hero_aibroker, merge UI enhancements 2026-02-12 14:58:37 +00:00

mik-tf added 1 commit 2026-02-13 18:41:49 +00:00

fix: clippy warnings and correct binary name in buildenv.sh ... 6ff2c2dad1

- Fix or_then_unwrap clippy lint in CLI
- Fix manual_strip clippy lint in CLI
- Rename llmbroker-cli to aibroker_cli in buildenv.sh (naming convention)

mik-tf added 1 commit 2026-02-13 19:01:12 +00:00

fix(ci): use correct binary name and robust test scripts ... c0e937e970

- CI test.yaml used ./target/release/aibroker but binary is hero_aibroker
- Replace inlined smoke test steps with 'make test-smoke' (Makefile compliance)
- Use PID tracking instead of pkill pattern matching in run-smoke-tests.sh
- Add --max-time 10 to all curl calls to prevent hangs in containers

mik-tf added 1 commit 2026-02-13 19:10:49 +00:00

fix: chat model dropdown uses config models instead of empty runtime list ... dcb6ff7a22

models.list returns runtime-validated models (0 without live providers).
models.config returns all 46 configured models, which is what the chat
dropdown should use for autocomplete.

mik-tf force-pushed development_hero_zero_standardize from dcb6ff7a22 to 0160090485 2026-02-13 19:12:27 +00:00 Compare

mik-tf added 1 commit 2026-02-13 19:18:52 +00:00

fix: accept both singular and plural API key env vars ... 0a2aa36778

Config now reads OPENROUTER_API_KEY (canonical per env_secrets skill)
in addition to OPENROUTER_API_KEYS (multi-key). Same for OPENAI, GROQ,
and SAMBANOVA. This was a pre-existing issue where providers were never
initialized because the env file uses singular names.

mik-tf added 1 commit 2026-02-13 19:32:21 +00:00

fix: metrics IP tracking middleware + dynamic API docs from OpenRPC spec ... 46605cacfd

Metrics: Replace per-handler increment_requests() with a middleware layer
that extracts client IP and tracks per-IP request/error counts. The
Metrics tab now shows actual IP data instead of 'No data'.

API Docs: Replace 320 lines of hardcoded HTML with a JS function that
fetches /openrpc.json and renders Bootstrap accordion dynamically. Docs
now stay in sync with the spec automatically.

mik-tf changed title from WIP: standardize: port 3385, binary name hero_aibroker, merge UI enhancements to standardize: port 3385, binary hero_aibroker, metrics middleware, dynamic API docs 2026-02-13 19:47:15 +00:00

mik-tf added 1 commit 2026-02-13 19:56:10 +00:00

feat: add MCP connection info and setup instructions to MCP tab ... 5524be6681

- Connection card with endpoint, protocol, SSE transport, auth info
- Claude Code setup command with copy button
- Claude Desktop JSON config with copy button
- All computed client-side from window.location

mik-tf commented 2026-02-13 19:58:20 +00:00

Author

Owner

Copy link

@thabeta I implemented all your feedback. This should be good to review. Thanks!

@thabeta I implemented all your feedback. This should be good to review. Thanks!

mik-tf changed title from standardize: port 3385, binary hero_aibroker, metrics middleware, dynamic API docs to Add admin dashboard, per-IP metrics, and ecosystem standardization 2026-02-16 15:41:32 +00:00

mik-tf referenced this pull request 2026-02-19 03:00:02 +00:00

Add admin dashboard, per-IP metrics, and ecosystem standardization #7

mik-tf commented 2026-02-19 03:00:10 +00:00

Author

Owner

Copy link

Superseded by #7 — consolidated to development_mik branch with latest development merged in.

Superseded by #7 — consolidated to `development_mik` branch with latest `development` merged in.

mik-tf closed this pull request 2026-02-19 03:00:21 +00:00

All checks were successful

Hide all checks

Test / lint (pull_request) Successful in 25s

Details

Test / test (pull_request) Successful in 2m13s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_aibroker!5

No description provided.