Operational: Catalog refresh spawns unbounded background tasks #124

New issue

Open

opened 2026-05-11 23:09:00 +00:00 by thabeta · 0 comments

thabeta commented

2026-05-11 23:09:00 +00:00

Owner

Severity: Medium

Location

crates/hero_aibroker_server/src/main.rs — catalog refresh loop

Finding

For each configured provider and the OpenRouter catalog, a separate tokio::spawn creates a background refresh task:

for cat in &config.provider_catalogs {
    let cat = cat.clone();
    tokio::spawn(async move {
        // ... infinite loop with ticker
    });
}

No limit on number of spawned tasks
No way to stop or restart tasks
No error handling for task panics
If a catalog refresh task panics, it's silently lost

Impact

Unbounded task growth with many providers
No visibility into refresh task health
Panicked tasks are never restarted
Cannot gracefully shut down catalog refreshes

Recommendation

Use a structured task manager with lifecycle control
Add panic recovery for background tasks
Limit concurrent catalog fetches
Add health check for catalog freshness
Graceful shutdown for background tasks

## Severity: Medium ## Location `crates/hero_aibroker_server/src/main.rs` — catalog refresh loop ## Finding For each configured provider and the OpenRouter catalog, a separate `tokio::spawn` creates a background refresh task: ```rust for cat in &config.provider_catalogs { let cat = cat.clone(); tokio::spawn(async move { // ... infinite loop with ticker }); } ``` - No limit on number of spawned tasks - No way to stop or restart tasks - No error handling for task panics - If a catalog refresh task panics, it's silently lost ## Impact - Unbounded task growth with many providers - No visibility into refresh task health - Panicked tasks are never restarted - Cannot gracefully shut down catalog refreshes ## Recommendation - Use a structured task manager with lifecycle control - Add panic recovery for background tasks - Limit concurrent catalog fetches - Add health check for catalog freshness - Graceful shutdown for background tasks