Support socks5 routing to mycelium #29
No reviewers
Labels
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
geomind_code/webgateway!29
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "support-socks5"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
#5
can we update readme with new added configs as well?
@ -63,0 +87,4 @@Subsystem: "socks5",Name: "connections_total",Help: "Total SOCKS5 proxy connections.",}, []string{"client_ip"})can we add visualization to these metrics in grafana/dashboards/webgateway.json
@ -0,0 +75,4 @@if err != nil {return fmt.Errorf("failed to load socks5metrics module: %w", err)}a.metrics = metricsModIface.(*metrics.Socks5MetricsHandler)can we use safe type assertion?
@ -0,0 +108,4 @@}if err := a.client.DisconnectProxy(); err != nil {a.logger.Warn("Failed to disconnect Mycelium proxy", zap.Error(err))}the function returns error so why we are only logging the error?
@ -0,0 +142,4 @@}// Connect to Mycelium's SOCKS5 and relay everythingmyceliumConn, err := net.Dial("tcp", a.MyceliumSOCKS5)can we have timeout here?
mycelium/circle_ops#635 (comment)
here the mycelium issue is fixed now and we can go ahead and merge this one