Writer consumed without finalize() in all config mutation functions #6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
All four config mutation functions (tag_add, tag_delete, store_add, store_delete) take Writer by value, write data to the temporary flist file, but never call finalize(). The Writer struct has no Drop implementation, so the temp file is simply abandoned and the final destination path is never updated.
File: myfs-core/src/config.rs:20-80
Any CLI command that calls these functions appears to succeed but silently discards all changes. If Writer::new was called with remove=true, the original file is deleted and the temp file is also abandoned - double data loss.
Severity: critical | Confidence: high
The described bug (Writer struct consumed without finalize(), potential double data loss with remove=true) is a well-documented critical-severity issue, but the referenced file myfs-core/src/config.rs does not exist in the geomind_code/geoip repository. This project is a MaxMind GeoIP lookup service with no Writer, config mutation functions (tag_add, store_add, etc.), or FUSE-related code. The issue was likely filed against the wrong repository.
Severity: critical | Confidence: high (bug is real in the correct codebase, but does not apply here)