MahmoudEmad/herolib
1
0
Fork 0
Code Issues 55 Pull Requests 1 Actions Packages Projects Releases 26 Wiki Activity

Update install script #182

Merged
scottyeager merged 5 commits from development_installer into development 2025-11-14 10:23:57 +00:00
Conversation 9 Commits 5 Files Changed 2 +245 -2325
scottyeager commented 2025-10-15 23:50:14 +00:00 (Migrated from github.com)
Copy Link

This is a WIP to improve the install_v.sh script.

Done:

  • Use a main function
  • All global vars to top of file
  • Remove commented code
  • Split OS update from package install steps
  • Cleanup redis startup feature and put it behind a flag (we don't need redis when we are just building the hero cli, for example)

Comments and questions below.

This is a WIP to improve the `install_v.sh` script. Done: - Use a main function - All global vars to top of file - Remove commented code - Split OS update from package install steps - Cleanup redis startup feature and put it behind a flag (we don't need redis when we are just building the hero cli, for example) Comments and questions below.
scottyeager (Migrated from github.com) reviewed 2025-10-15 23:51:19 +00:00
install_v.sh
@@ -4,2 +4,2 @@
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
cd "$SCRIPT_DIR"
#==============================================================================
# GLOBAL VARIABLES
scottyeager (Migrated from github.com) commented 2025-10-15 23:51:19 +00:00
Copy Link

Moved into main function below

Moved into main function below
scottyeager (Migrated from github.com) reviewed 2025-10-15 23:51:59 +00:00
install_v.sh
@@ -381,3 +300,4 @@
# Remove v-analyzer path from rc files
for RC_FILE in ~/.zshrc ~/.bashrc; do
if [ -f "$RC_FILE" ]; then
scottyeager (Migrated from github.com) commented 2025-10-15 23:51:59 +00:00
Copy Link

Function was not in use

Function was not in use
scottyeager (Migrated from github.com) reviewed 2025-10-15 23:53:38 +00:00
install_v.sh
@@ -400,0 +321,4 @@
function start_redis_service() {
echo "Attempting to start Redis service..."
# Check if redis-server is even installed
if ! command_exists redis-server; then
scottyeager (Migrated from github.com) commented 2025-10-15 23:53:37 +00:00
Copy Link

We already branch on OS when installing packages, so the package_install function is largely redundant. The apt command is confusing so is pulled to a function and explained.

We already branch on OS when installing packages, so the `package_install` function is largely redundant. The apt command is confusing so is pulled to a function and explained.
scottyeager (Migrated from github.com) reviewed 2025-10-15 23:58:28 +00:00
install_v.sh
@@ -556,3 +403,3 @@
echo "V built successfully. Creating symlink..."
run_sudo ./v symlink
scottyeager (Migrated from github.com) commented 2025-10-15 23:58:28 +00:00
Copy Link

Why does this script do a system update, anyway? I never met an install script that wants to do this

Why does this script do a system update, anyway? I never met an install script that wants to do this
scottyeager (Migrated from github.com) reviewed 2025-10-15 23:59:15 +00:00
install_v.sh
@@ -568,3 +414,4 @@
}
scottyeager (Migrated from github.com) commented 2025-10-15 23:59:15 +00:00
Copy Link

Why delete the lock files?

Why delete the lock files?
scottyeager (Migrated from github.com) reviewed 2025-10-16 00:00:52 +00:00
install_v.sh
@@ -624,0 +500,4 @@
--start-redis)
START_REDIS=true
;;
*)
scottyeager (Migrated from github.com) commented 2025-10-16 00:00:52 +00:00
Copy Link

Why does this script create a new user on Arch (but no other Linux)?

Why does this script create a new user on Arch (but no other Linux)?
scottyeager (Migrated from github.com) reviewed 2025-10-16 00:12:10 +00:00
install_v.sh
scottyeager (Migrated from github.com) commented 2025-10-16 00:12:10 +00:00
Copy Link

I tried to simplify things substantially here. There were some things I didn't understand, so maybe it cannot actually be this simple. Need to confirm whether systemctl/brew services really don't work in github actions runners.

Also I don't understand why we used systemctl start? This starts the service once but not again on boot

I tried to simplify things substantially here. There were some things I didn't understand, so maybe it cannot actually be this simple. Need to confirm whether systemctl/brew services really don't work in github actions runners. Also I don't understand why we used `systemctl start`? This starts the service once but not again on boot
scottyeager (Migrated from github.com) reviewed 2025-10-16 00:13:21 +00:00
install_v.sh
scottyeager (Migrated from github.com) commented 2025-10-16 00:13:21 +00:00
Copy Link

Aside from condensing into main function, the top level flow is mostly unchanged aside from adding the flag for starting redis.

Aside from condensing into main function, the top level flow is mostly unchanged aside from adding the flag for starting redis.
scottyeager commented 2025-11-14 09:15:25 +00:00 (Migrated from github.com)
Copy Link

It works now in an Ubuntu container. We can check about Alpine later.

It works now in an Ubuntu container. We can check about Alpine later.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
openhands
priority_critical
priority_major
priority_minor
process_duplicate
process_wontfix
question
Further information is requested
task
type_bug
type_feature
type_question
type_story
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
MahmoudEmad
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MahmoudEmad/herolib#182
No description provided.
Delete Branch "development_installer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?