MahmoudEmad/herolib
1
0
Fork 0
Code Issues 55 Pull Requests 1 Actions Packages Projects Releases 26 Wiki Activity

perf: Limit command output in SSH agent functions

Browse Source 
- Limit `pgrep` output in agent cleanup
- Limit `find` output for socket validation
- Limit `ssh-add` output for key initialization
This commit is contained in:
Mahmoud-Emad
2025-09-14 15:26:55 +03:00
parent f061c0285a
commit 42cf8949f7
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/osal/sshagent/sshagent.v
View File

@@ -62,8 +62,8 @@ pub fn (mut agent SSHAgent) is_agent_responsive() bool {
pub fn (mut agent SSHAgent) cleanup_orphaned_agents() ! { pub fn (mut agent SSHAgent) cleanup_orphaned_agents() ! {
user := os.getenv('USER') user := os.getenv('USER')
// Find ssh-agent processes for current user // Find ssh-agent processes for current user (limit to prevent memory issues)
res := os.execute('pgrep -u ${user} ssh-agent') res := os.execute('pgrep -u ${user} ssh-agent | head -20')
if res.exit_code == 0 && res.output.len > 0 { if res.exit_code == 0 && res.output.len > 0 {
pids := res.output.trim_space().split('\n') pids := res.output.trim_space().split('\n')
@@ -82,8 +82,8 @@ pub fn (mut agent SSHAgent) cleanup_orphaned_agents() ! {
// check if specific agent PID is valid and responsive // check if specific agent PID is valid and responsive
fn (mut agent SSHAgent) is_agent_pid_valid(pid int) bool { fn (mut agent SSHAgent) is_agent_pid_valid(pid int) bool {
// Try to find socket for this PID // Try to find socket for this PID (limit output to prevent memory issues)
res := os.execute('find /tmp -name "agent.*" -user ${os.getenv('USER')} 2>/dev/null | head -10') res := os.execute('find /tmp -maxdepth 1 -name "agent.*" -user ${os.getenv('USER')} 2>/dev/null | head -5')
if res.exit_code != 0 { if res.exit_code != 0 {
return false return false
} }
@@ -154,9 +154,9 @@ pub fn (mut agent SSHAgent) diagnostics() map[string]string {
// get all keys from sshagent and from the local .ssh dir // get all keys from sshagent and from the local .ssh dir
pub fn (mut agent SSHAgent) init() ! { pub fn (mut agent SSHAgent) init() ! {
// first get keys out of ssh-add // first get keys out of ssh-add (limit output to prevent memory issues)
agent.keys = []SSHKey{} agent.keys = []SSHKey{}
res := os.execute('ssh-add -L') res := os.execute('ssh-add -L | head -100')
if res.exit_code == 0 { if res.exit_code == 0 {
for line in res.output.split('\n') { for line in res.output.split('\n') {
if line.trim(' ') == '' { if line.trim(' ') == '' {